Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

bpo-26067: Do not fail test_shutil / chown when gid/uid cannot be resolved (#19032) 

* bpo-26067: Do not fail test_shutil.chown when gid/uid cannot be resolved

There is no guarantee that the users primary uid or gid can be resolved
in the unix group/account databases. Skip the last part of the chown
test if we cannot resolve the gid or uid to a name.

* 📜🤖 Added by blurb_it.

* Address review feedback

* address review feedback correctly

* fix typo

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
This commit is contained in:
Matthias Braun 2020-03-17 09:51:44 -07:00 committed by GitHub
parent 982307b9cc
commit 52268941f3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Lib/test/test_shutil.py
View File

@ -1666,8 +1666,13 @@ class TestMisc(BaseTest, unittest.TestCase):
shutil.chown(dirname, group=gid) shutil.chown(dirname, group=gid)
check_chown(dirname, gid=gid) check_chown(dirname, gid=gid)
try:
user = pwd.getpwuid(uid)[0] user = pwd.getpwuid(uid)[0]
group = grp.getgrgid(gid)[0] group = grp.getgrgid(gid)[0]
except KeyError:
# On some systems uid/gid cannot be resolved.
pass
else:
shutil.chown(filename, user, group) shutil.chown(filename, user, group)
check_chown(filename, uid, gid) check_chown(filename, uid, gid)
shutil.chown(dirname, user, group) shutil.chown(dirname, user, group)

1
Misc/NEWS.d/next/Tests/2020-03-16-20-54-55.bpo-26067.m18_VV.rst Normal file
View File

@ -0,0 +1 @@
Do not fail test_shutil test_chown test when uid or gid of user cannot be resolved to a name.