mirror of https://github.com/python/cpython
bpo-40020: Fix realloc leak on failure in growable_comment_array_add (GH-19083)
Fix a leak and subsequent crash in parsetok.c caused by realloc misuse on a rare codepath. Realloc returns a null pointer on failure, and then growable_comment_array_deallocate crashes later when it dereferences it.
This commit is contained in:
parent
fc2d8d62af
commit
51e3e450fb
|
@ -0,0 +1 @@
|
|||
Fix a leak and subsequent crash in parsetok.c caused by realloc misuse on a rare codepath.
|
|
@ -37,11 +37,13 @@ growable_comment_array_init(growable_comment_array *arr, size_t initial_size) {
|
|||
static int
|
||||
growable_comment_array_add(growable_comment_array *arr, int lineno, char *comment) {
|
||||
if (arr->num_items >= arr->size) {
|
||||
arr->size *= 2;
|
||||
arr->items = realloc(arr->items, arr->size * sizeof(*arr->items));
|
||||
if (!arr->items) {
|
||||
size_t new_size = arr->size * 2;
|
||||
void *new_items_array = realloc(arr->items, new_size * sizeof(*arr->items));
|
||||
if (!new_items_array) {
|
||||
return 0;
|
||||
}
|
||||
arr->items = new_items_array;
|
||||
arr->size = new_size;
|
||||
}
|
||||
|
||||
arr->items[arr->num_items].lineno = lineno;
|
||||
|
|
Loading…
Reference in New Issue