Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

bpo-43399: Fix ElementTree.extend not working on iterators (GH-24751)

This commit is contained in:
Alex Prengère 2021-03-30 23:11:29 +02:00 committed by GitHub
parent 73b20ae2fb
commit 51a85ddce8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Lib/test/test_xml_etree.py
View File

@ -330,6 +330,9 @@ class ElementTreeTest(unittest.TestCase):
elem.extend([e])
self.serialize_check(elem, '<body><tag /><tag2 /></body>')
elem.remove(e)
elem.extend(iter([e]))
self.serialize_check(elem, '<body><tag /><tag2 /></body>')
elem.remove(e)
element = ET.Element("tag", key="value")
self.serialize_check(element, '<tag key="value" />') # 1

2
Lib/xml/etree/ElementTree.py
View File

@ -252,7 +252,7 @@ class Element:
"""
for element in elements:
self._assert_is_element(element)
self._children.extend(elements)
self._children.append(element)
def insert(self, index, subelement):
"""Insert *subelement* at position *index*."""

1
Misc/ACKS
View File

@ -1381,6 +1381,7 @@ Matheus Vieira Portela
Davin Potts
Guillaume Pratte
Florian Preinstorfer
Alex Prengère
Amrit Prem
Paul Prescod
Donovan Preston

2
Misc/NEWS.d/next/Library/2021-03-04-17-53-46.bpo-43399.Wn95u-.rst Normal file
View File

@ -0,0 +1,2 @@
Fix ``ElementTree.extend`` not working on iterators when using the
Python implementation