Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Reorder some test's decorators (GH-108804) 

For example, do not demand the 'cpu' resource if the test cannot be run
due to non-working threads.
This commit is contained in:
Serhiy Storchaka 2023-09-03 15:21:43 +03:00 committed by GitHub
parent 9c995abd78
commit 509bb61977
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Lib/test/test_io.py
View File

@ -1541,8 +1541,8 @@ class BufferedReaderTest(unittest.TestCase, CommonBufferedTests):
self.assertEqual(b"abcdefg", bufio.read()) self.assertEqual(b"abcdefg", bufio.read())
@support.requires_resource('cpu')
@threading_helper.requires_working_threading() @threading_helper.requires_working_threading()
@support.requires_resource('cpu')
def test_threads(self): def test_threads(self):
try: try:
# Write out many bytes with exactly the same number of 0's, # Write out many bytes with exactly the same number of 0's,
@ -1930,8 +1930,8 @@ class BufferedWriterTest(unittest.TestCase, CommonBufferedTests):
f.truncate() f.truncate()
self.assertEqual(f.tell(), buffer_size + 2) self.assertEqual(f.tell(), buffer_size + 2)
@support.requires_resource('cpu')
@threading_helper.requires_working_threading() @threading_helper.requires_working_threading()
@support.requires_resource('cpu')
def test_threads(self): def test_threads(self):
try: try:
# Write out many bytes from many threads and test they were # Write out many bytes from many threads and test they were

4
Lib/test/test_site.py
View File

@ -465,10 +465,10 @@ class ImportSideEffectTests(unittest.TestCase):
else: else:
self.fail("sitecustomize not imported automatically") self.fail("sitecustomize not imported automatically")
@test.support.requires_resource('network')
@test.support.system_must_validate_cert
@unittest.skipUnless(hasattr(urllib.request, "HTTPSHandler"), @unittest.skipUnless(hasattr(urllib.request, "HTTPSHandler"),
'need SSL support to download license') 'need SSL support to download license')
@test.support.requires_resource('network')
@test.support.system_must_validate_cert
def test_license_exists_at_url(self): def test_license_exists_at_url(self):
# This test is a bit fragile since it depends on the format of the # This test is a bit fragile since it depends on the format of the
# string displayed by license in the absence of a LICENSE file. # string displayed by license in the absence of a LICENSE file.