Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Merged revisions 75224 via svnmerge from 

svn+ssh://pythondev@svn.python.org/python/branches/py3k

................
  r75224 | benjamin.peterson | 2009-10-03 15:27:13 -0500 (Sat, 03 Oct 2009) | 9 lines

  Merged revisions 75223 via svnmerge from
  svn+ssh://pythondev@svn.python.org/python/trunk

  ........
    r75223 | benjamin.peterson | 2009-10-03 15:23:24 -0500 (Sat, 03 Oct 2009) | 1 line

    #7050 fix a SystemError when using tuple unpacking and augmented assignment
  ........
................
This commit is contained in:
Benjamin Peterson 2009-10-03 20:28:47 +00:00
parent 01c549642a
commit 4fac706833
2 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Lib/test/test_augassign.py
View File

@ -19,6 +19,9 @@ class AugAssignTest(unittest.TestCase):
x /= 2 x /= 2
self.assertEquals(x, 3.0) self.assertEquals(x, 3.0)
def test_with_unpacking(self):
self.assertRaises(SyntaxError, compile, "x, b += 3", "<test>", "exec")
def testInList(self): def testInList(self):
x = [2] x = [2]
x[0] += 1 x[0] += 1

13
Python/ast.c
View File

@ -2105,6 +2105,19 @@ ast_for_expr_stmt(struct compiling *c, const node *n)
return NULL; return NULL;
if(!set_context(c, expr1, Store, ch)) if(!set_context(c, expr1, Store, ch))
return NULL; return NULL;
/* set_context checks that most expressions are not the left side.
Augmented assignments can only have a name, a subscript, or an
attribute on the left, though, so we have to explicitly check for
those. */
switch (expr1->kind) {
case Name_kind:
case Attribute_kind:
case Subscript_kind:
break;
default:
ast_error(ch, "illegal expression for augmented assignment");
return NULL;
}
ch = CHILD(n, 2); ch = CHILD(n, 2);
if (TYPE(ch) == testlist) if (TYPE(ch) == testlist)