mirror of https://github.com/python/cpython
Issue #19596: Set untestable tests in test_importlib to None
to avoid reporting success on empty tests.
This commit is contained in:
parent
30d8e167ff
commit
4accf45f0e
|
@ -16,21 +16,11 @@ class FinderTests(abc.FinderTests):
|
|||
found = machinery.BuiltinImporter.find_module(builtin_util.NAME)
|
||||
self.assertTrue(found)
|
||||
|
||||
def test_package(self):
|
||||
# Built-in modules cannot be a package.
|
||||
pass
|
||||
# Built-in modules cannot be a package.
|
||||
test_package = test_package_in_package = test_package_over_module = None
|
||||
|
||||
def test_module_in_package(self):
|
||||
# Built-in modules cannobt be in a package.
|
||||
pass
|
||||
|
||||
def test_package_in_package(self):
|
||||
# Built-in modules cannot be a package.
|
||||
pass
|
||||
|
||||
def test_package_over_module(self):
|
||||
# Built-in modules cannot be a package.
|
||||
pass
|
||||
# Built-in modules cannot be in a package.
|
||||
test_module_in_package = None
|
||||
|
||||
def test_failure(self):
|
||||
assert 'importlib' not in sys.builtin_module_names
|
||||
|
|
|
@ -32,17 +32,11 @@ class LoaderTests(abc.LoaderTests):
|
|||
module = self.load_module(builtin_util.NAME)
|
||||
self.verify(module)
|
||||
|
||||
def test_package(self):
|
||||
# Built-in modules cannot be a package.
|
||||
pass
|
||||
# Built-in modules cannot be a package.
|
||||
test_package = test_lacking_parent = None
|
||||
|
||||
def test_lacking_parent(self):
|
||||
# Built-in modules cannot be a package.
|
||||
pass
|
||||
|
||||
def test_state_after_failure(self):
|
||||
# Not way to force an imoprt failure.
|
||||
pass
|
||||
# No way to force an import failure.
|
||||
test_state_after_failure = None
|
||||
|
||||
def test_module_reuse(self):
|
||||
# Test that the same module is used in a reload.
|
||||
|
|
|
@ -17,21 +17,14 @@ class FinderTests(abc.FinderTests):
|
|||
def test_module(self):
|
||||
self.assertTrue(self.find_module(util.NAME))
|
||||
|
||||
def test_package(self):
|
||||
# No extension module as an __init__ available for testing.
|
||||
pass
|
||||
# No extension module as an __init__ available for testing.
|
||||
test_package = test_package_in_package = None
|
||||
|
||||
def test_module_in_package(self):
|
||||
# No extension module in a package available for testing.
|
||||
pass
|
||||
# No extension module in a package available for testing.
|
||||
test_module_in_package = None
|
||||
|
||||
def test_package_in_package(self):
|
||||
# No extension module as an __init__ available for testing.
|
||||
pass
|
||||
|
||||
def test_package_over_module(self):
|
||||
# Extension modules cannot be an __init__ for a package.
|
||||
pass
|
||||
# Extension modules cannot be an __init__ for a package.
|
||||
test_package_over_module = None
|
||||
|
||||
def test_failure(self):
|
||||
self.assertIsNone(self.find_module('asdfjkl;'))
|
||||
|
|
|
@ -38,13 +38,11 @@ class LoaderTests(abc.LoaderTests):
|
|||
self.assertIsInstance(module.__loader__,
|
||||
machinery.ExtensionFileLoader)
|
||||
|
||||
def test_package(self):
|
||||
# No extension module as __init__ available for testing.
|
||||
pass
|
||||
# No extension module as __init__ available for testing.
|
||||
test_package = None
|
||||
|
||||
def test_lacking_parent(self):
|
||||
# No extension module in a package available for testing.
|
||||
pass
|
||||
# No extension module in a package available for testing.
|
||||
test_lacking_parent = None
|
||||
|
||||
def test_module_reuse(self):
|
||||
with util.uncache(ext_util.NAME):
|
||||
|
@ -52,9 +50,8 @@ class LoaderTests(abc.LoaderTests):
|
|||
module2 = self.load_module(ext_util.NAME)
|
||||
self.assertIs(module1, module2)
|
||||
|
||||
def test_state_after_failure(self):
|
||||
# No easy way to trigger a failure after a successful import.
|
||||
pass
|
||||
# No easy way to trigger a failure after a successful import.
|
||||
test_state_after_failure = None
|
||||
|
||||
def test_unloadable(self):
|
||||
name = 'asdfjkl;'
|
||||
|
|
|
@ -25,13 +25,11 @@ class FinderTests(abc.FinderTests):
|
|||
loader = self.find('__phello__.spam', ['__phello__'])
|
||||
self.assertTrue(hasattr(loader, 'load_module'))
|
||||
|
||||
def test_package_in_package(self):
|
||||
# No frozen package within another package to test with.
|
||||
pass
|
||||
# No frozen package within another package to test with.
|
||||
test_package_in_package = None
|
||||
|
||||
def test_package_over_module(self):
|
||||
# No easy way to test.
|
||||
pass
|
||||
# No easy way to test.
|
||||
test_package_over_module = None
|
||||
|
||||
def test_failure(self):
|
||||
loader = self.find('<not real>')
|
||||
|
|
|
@ -65,9 +65,8 @@ class LoaderTests(abc.LoaderTests):
|
|||
self.assertEqual(repr(module),
|
||||
"<module '__hello__' (frozen)>")
|
||||
|
||||
def test_state_after_failure(self):
|
||||
# No way to trigger an error in a frozen module.
|
||||
pass
|
||||
# No way to trigger an error in a frozen module.
|
||||
test_state_after_failure = None
|
||||
|
||||
def test_unloadable(self):
|
||||
assert machinery.FrozenImporter.find_module('_not_real') is None
|
||||
|
|
|
@ -51,6 +51,9 @@ Library
|
|||
Tests
|
||||
-----
|
||||
|
||||
- Issue #19596: Set untestable tests in test_importlib to None to avoid
|
||||
reporting success on empty tests.
|
||||
|
||||
- Issue #19440: Clean up test_capi by removing an unnecessary __future__
|
||||
import, converting from test_main to unittest.main, and running the
|
||||
_testcapi module tests within a unittest TestCase.
|
||||
|
|
Loading…
Reference in New Issue