Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

GH-92184: Convert os.altsep to '/' in filenames when creating ZipInfo objects (#92185) 

This causes the zipfile module to also consider the character defined by
`os.altsep` (if there is one) to be a path separator and convert it to a
forward slash, as defined by the zip specification.

A logical no-op on all known platforms today as os.altsep is currently only set to a meaningful value on Windows (where it is "/").
This commit is contained in:
Carey Metcalfe 2023-05-11 01:25:16 -06:00 committed by GitHub
parent fcd5fb49b1
commit 4abfe6a14b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/zipfile/__init__.py
View File

@ -352,6 +352,8 @@ def _sanitize_filename(filename):
# ZIP format specification.
if os.sep != "/" and os.sep in filename:
filename = filename.replace(os.sep, "/")
if os.altsep and os.altsep != "/" and os.altsep in filename:
filename = filename.replace(os.altsep, "/")
return filename

3
Misc/NEWS.d/next/Library/2022-05-02-16-21-05.gh-issue-92184.hneGVW.rst Normal file
View File

@ -0,0 +1,3 @@
When creating zip files using :mod:`zipfile`, ``os.altsep``, if not ``None``,
will always be treated as a path separator even when it is not ``/``.
Patch by Carey Metcalfe.