From 484c913ed9fc438cedd2757d6124ab1bac4239be Mon Sep 17 00:00:00 2001 From: Serhiy Storchaka Date: Sun, 5 Jun 2016 10:48:36 +0300 Subject: [PATCH] Issue #27225: Fixed a reference leak in type_new when setting __new__ fails. Patch by Xiang Zhang. --- Objects/typeobject.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Objects/typeobject.c b/Objects/typeobject.c index 19e65963d58..317334f739a 100644 --- a/Objects/typeobject.c +++ b/Objects/typeobject.c @@ -2575,8 +2575,10 @@ type_new(PyTypeObject *metatype, PyObject *args, PyObject *kwds) tmp = PyStaticMethod_New(tmp); if (tmp == NULL) goto error; - if (_PyDict_SetItemId(dict, &PyId___new__, tmp) < 0) + if (_PyDict_SetItemId(dict, &PyId___new__, tmp) < 0) { + Py_DECREF(tmp); goto error; + } Py_DECREF(tmp); }