Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Issue #27809: Use _PyObject_FastCallDict() 

Modify:

* init_subclass()
* builtin___build_class__()

Fix also a bug in init_subclass(): check for super() failure.
This commit is contained in:
Victor Stinner 2016-08-22 23:33:13 +02:00
parent 155ea65e5c
commit 463b86a881
2 changed files with 18 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
Objects/typeobject.c
View File

@ -7007,30 +7007,28 @@ set_names(PyTypeObject *type)
static int static int
init_subclass(PyTypeObject *type, PyObject *kwds) init_subclass(PyTypeObject *type, PyObject *kwds)
{ {
PyObject *super, *func, *tmp, *tuple; PyObject *super, *func, *result;
PyObject *args[2] = {(PyObject *)type, (PyObject *)type};
super = PyObject_CallFunctionObjArgs((PyObject *) &PySuper_Type, super = _PyObject_FastCall((PyObject *)&PySuper_Type, args, 2);
type, type, NULL); if (super == NULL) {
func = _PyObject_GetAttrId(super, &PyId___init_subclass__);
Py_DECREF(super);
if (func == NULL)
return -1; return -1;
tuple = PyTuple_New(0);
if (tuple == NULL) {
Py_DECREF(func);
return 0;
} }
tmp = PyObject_Call(func, tuple, kwds); func = _PyObject_GetAttrId(super, &PyId___init_subclass__);
Py_DECREF(tuple); Py_DECREF(super);
Py_DECREF(func); if (func == NULL) {
if (tmp == NULL)
return -1; return -1;
}
Py_DECREF(tmp);
result = _PyObject_FastCallDict(func, NULL, 0, kwds);
Py_DECREF(func);
if (result == NULL) {
return -1;
}
Py_DECREF(result);
return 0; return 0;
} }

12
Python/bltinmodule.c
View File

@ -155,16 +155,8 @@ builtin___build_class__(PyObject *self, PyObject *args, PyObject *kwds)
} }
} }
else { else {
PyObject *pargs = PyTuple_Pack(2, name, bases); PyObject *pargs[2] = {name, bases};
if (pargs == NULL) { ns = _PyObject_FastCallDict(prep, pargs, 2, mkw);
Py_DECREF(prep);
Py_DECREF(meta);
Py_XDECREF(mkw);
Py_DECREF(bases);
return NULL;
}
ns = PyEval_CallObjectWithKeywords(prep, pargs, mkw);
Py_DECREF(pargs);
Py_DECREF(prep); Py_DECREF(prep);
} }
if (ns == NULL) { if (ns == NULL) {