From 44c19eccf9fd8258f8d939fe30b79b644b2c235a Mon Sep 17 00:00:00 2001 From: Yury Selivanov Date: Sun, 11 Sep 2016 21:39:31 -0400 Subject: [PATCH] Issue #27456: asyncio: Set TCP_NODELAY by default. --- Lib/asyncio/selector_events.py | 16 ++++++++++++++++ Misc/NEWS | 2 ++ 2 files changed, 18 insertions(+) diff --git a/Lib/asyncio/selector_events.py b/Lib/asyncio/selector_events.py index c57f509a12b..c91ab04f3c0 100644 --- a/Lib/asyncio/selector_events.py +++ b/Lib/asyncio/selector_events.py @@ -39,6 +39,17 @@ def _test_selector_event(selector, fd, event): return bool(key.events & event) +if hasattr(socket, 'TCP_NODELAY'): + def _set_nodelay(sock): + if (sock.family in {socket.AF_INET, socket.AF_INET6} and + sock.type == socket.SOCK_STREAM and + sock.proto == socket.IPPROTO_TCP): + sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1) +else: + def _set_nodelay(sock): + pass + + class BaseSelectorEventLoop(base_events.BaseEventLoop): """Selector event loop. @@ -640,6 +651,11 @@ class _SelectorSocketTransport(_SelectorTransport): self._eof = False self._paused = False + # Disable the Nagle algorithm -- small writes will be + # sent without waiting for the TCP ACK. This generally + # decreases the latency (in some cases significantly.) + _set_nodelay(self._sock) + self._loop.call_soon(self._protocol.connection_made, self) # only start reading when connection_made() has been called self._loop.call_soon(self._loop.add_reader, diff --git a/Misc/NEWS b/Misc/NEWS index d1c36f0fbf7..73286b7eab6 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -254,6 +254,8 @@ Library - Issue #21201: Improves readability of multiprocessing error message. Thanks to Wojciech Walczak for patch. +- Issue #27456: asyncio: Set TCP_NODELAY by default. + IDLE ----