Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

gh-104018: disallow "z" format specifier in %-format of byte strings (GH-104033) 

PEP-0682 specified that %-formatting would not support the "z" specifier,
but it was unintentionally allowed for bytes. This PR makes use of the "z"
flag an error for %-formatting in a bytestring.

Issue: #104018

---------

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
This commit is contained in:
John Belmonte 2023-05-02 04:47:14 +09:00 committed by GitHub
parent 5078eedc5b
commit 3ed8c88290
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/test/test_format.py
View File

@ -619,6 +619,8 @@ class FormatTest(unittest.TestCase):
error_msg = re.escape("unsupported format character 'z'") error_msg = re.escape("unsupported format character 'z'")
with self.assertRaisesRegex(ValueError, error_msg): with self.assertRaisesRegex(ValueError, error_msg):
"%z.1f" % 0 # not allowed in old style string interpolation "%z.1f" % 0 # not allowed in old style string interpolation
with self.assertRaisesRegex(ValueError, error_msg):
b"%z.1f" % 0
if __name__ == "__main__": if __name__ == "__main__":

1
Misc/NEWS.d/next/Core and Builtins/2023-05-01-12-03-52.gh-issue-104018.PFxGS4.rst Normal file
View File

@ -0,0 +1 @@
Disallow the "z" format specifier in %-format of bytes objects.

1
Objects/bytesobject.c
View File

@ -705,7 +705,6 @@ _PyBytes_FormatEx(const char *format, Py_ssize_t format_len,
case ' ': flags |= F_BLANK; continue; case ' ': flags |= F_BLANK; continue;
case '#': flags |= F_ALT; continue; case '#': flags |= F_ALT; continue;
case '0': flags |= F_ZERO; continue; case '0': flags |= F_ZERO; continue;
case 'z': flags |= F_NO_NEG_0; continue;
} }
break; break;
} }