mirror of https://github.com/python/cpython
gh-122546: use same filename for different exceptions in new repl (#123217)
* gh-122546: use same filename for different exceptions in new repl * +1
This commit is contained in:
parent
427b106162
commit
3d7b1a526d
|
@ -162,7 +162,7 @@ class InteractiveColoredConsole(code.InteractiveConsole):
|
|||
self.can_colorize = _colorize.can_colorize()
|
||||
|
||||
def showsyntaxerror(self, filename=None, **kwargs):
|
||||
super().showsyntaxerror(**kwargs)
|
||||
super().showsyntaxerror(filename=filename, **kwargs)
|
||||
|
||||
def _excepthook(self, typ, value, tb):
|
||||
import traceback
|
||||
|
|
10
Lib/code.py
10
Lib/code.py
|
@ -109,15 +109,7 @@ class InteractiveInterpreter:
|
|||
try:
|
||||
typ, value, tb = sys.exc_info()
|
||||
if filename and typ is SyntaxError:
|
||||
# Work hard to stuff the correct filename in the exception
|
||||
try:
|
||||
msg, (dummy_filename, lineno, offset, line) = value.args
|
||||
except ValueError:
|
||||
# Not the format we expect; leave it alone
|
||||
pass
|
||||
else:
|
||||
# Stuff in the right filename
|
||||
value = SyntaxError(msg, (filename, lineno, offset, line))
|
||||
value.filename = filename
|
||||
source = kwargs.pop('source', "")
|
||||
self._showtraceback(typ, value, None, source)
|
||||
finally:
|
||||
|
|
|
@ -1100,6 +1100,16 @@ class TestMain(TestCase):
|
|||
self.assertIn("spam", output)
|
||||
self.assertNotEqual(pathlib.Path(hfile.name).stat().st_size, 0)
|
||||
|
||||
@force_not_colorized
|
||||
def test_correct_filename_in_syntaxerrors(self):
|
||||
env = os.environ.copy()
|
||||
commands = "a b c\nexit()\n"
|
||||
output, exit_code = self.run_repl(commands, env=env)
|
||||
if "can't use pyrepl" in output:
|
||||
self.skipTest("pyrepl not available")
|
||||
self.assertIn("SyntaxError: invalid syntax", output)
|
||||
self.assertIn("<python-input-0>", output)
|
||||
|
||||
@force_not_colorized
|
||||
def test_proper_tracebacklimit(self):
|
||||
env = os.environ.copy()
|
||||
|
|
|
@ -0,0 +1,2 @@
|
|||
Consistently use same file name for different exceptions in the new repl.
|
||||
Patch by Sergey B Kirpichev.
|
Loading…
Reference in New Issue