gh-111380: Show SyntaxWarnings only once when parsing if invalid syntax is encouintered (#111381)

This commit is contained in:
Pablo Galindo Salgado 2023-10-27 12:19:34 +09:00 committed by GitHub
parent a254120f2f
commit 3d2f1f0b83
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 0 deletions

View File

@ -131,6 +131,18 @@ class TestLiterals(unittest.TestCase):
self.assertEqual(exc.lineno, 1)
self.assertEqual(exc.offset, 1)
# Check that the warning is raised ony once if there are syntax errors
with warnings.catch_warnings(record=True) as w:
warnings.simplefilter('always', category=SyntaxWarning)
with self.assertRaises(SyntaxError) as cm:
eval("'\\e' $")
exc = cm.exception
self.assertEqual(len(w), 1)
self.assertEqual(w[0].category, SyntaxWarning)
self.assertRegex(str(w[0].message), 'invalid escape sequence')
self.assertEqual(w[0].filename, '<string>')
def test_eval_str_invalid_octal_escape(self):
for i in range(0o400, 0o1000):
with self.assertWarns(SyntaxWarning):

View File

@ -0,0 +1,2 @@
Fix a bug that was causing :exc:`SyntaxWarning` to appear twice when parsing
if invalid syntax is encountered later. Patch by Pablo galindo

View File

@ -13,6 +13,11 @@
static int
warn_invalid_escape_sequence(Parser *p, const char *first_invalid_escape, Token *t)
{
if (p->call_invalid_rules) {
// Do not report warnings if we are in the second pass of the parser
// to avoid showing the warning twice.
return 0;
}
unsigned char c = *first_invalid_escape;
if ((t->type == FSTRING_MIDDLE || t->type == FSTRING_END) && (c == '{' || c == '}')) {
// in this case the tokenizer has already emitted a warning,