gh-124043: Disallow mixing `--with-trace-refs` and `--disable-gil` (#124078)

Tracing references is not currently thread-safe in the free-threaded build.
This commit is contained in:
Peter Bierma 2024-09-16 16:03:16 -04:00 committed by GitHub
parent 44052b5f18
commit 3b45df03a4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 10 additions and 0 deletions

View File

@ -0,0 +1,2 @@
Building using :option:`--with-trace-refs` is (temporarily) disallowed when the
GIL is disabled.

4
configure generated vendored
View File

@ -8234,6 +8234,10 @@ printf "%s\n" "#define Py_TRACE_REFS 1" >>confdefs.h
fi
if test "$disable_gil" = "yes" -a "$with_trace_refs" = "yes";
then
as_fn_error $? "--disable-gil cannot be used with --with-trace-refs" "$LINENO" 5
fi
# Check for --enable-pystats
{ printf "%s\n" "$as_me:${as_lineno-$LINENO}: checking for --enable-pystats" >&5

View File

@ -1777,6 +1777,10 @@ then
[Define if you want to enable tracing references for debugging purpose])
fi
if test "$disable_gil" = "yes" -a "$with_trace_refs" = "yes";
then
AC_MSG_ERROR([--disable-gil cannot be used with --with-trace-refs])
fi
# Check for --enable-pystats
AC_MSG_CHECKING([for --enable-pystats])