From 365aff3a9c3e421097782e5220790ee9ef849f2c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lars=20Gust=C3=A4bel?= Date: Sun, 13 Dec 2009 11:42:29 +0000 Subject: [PATCH] Merged revisions 76780 via svnmerge from svn+ssh://pythondev@svn.python.org/python/trunk ........ r76780 | lars.gustaebel | 2009-12-13 12:32:27 +0100 (Sun, 13 Dec 2009) | 21 lines Issue #7357: No longer suppress fatal extraction errors by default. TarFile's errorlevel argument controls how errors are handled that occur during extraction. There are three possible levels 0, 1 and 2. If errorlevel is set to 1 or 2 fatal errors (e.g. a full filesystem) are raised as exceptions. If it is set to 0, which is the default value, extraction errors are suppressed, and error messages are written to the debug log instead. But, if the debug log is not activated, which is the default as well, all these errors go unnoticed. The original intention was to imitate GNU tar which tries to extract as many members as possible instead of stopping on the first error. It turns out that this is no good default behaviour for a tar library. This patch simply changes the default value for the errorlevel argument from 0 to 1, so that fatal extraction errors are raised as EnvironmentError exceptions. ........ --- Lib/tarfile.py | 2 +- Misc/NEWS | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/Lib/tarfile.py b/Lib/tarfile.py index 55bb4e3f156..7a67e15d97b 100644 --- a/Lib/tarfile.py +++ b/Lib/tarfile.py @@ -1481,7 +1481,7 @@ class TarFile(object): ignore_zeros = False # If true, skips empty or invalid blocks and # continues processing. - errorlevel = 0 # If 0, fatal errors only appear in debug + errorlevel = 1 # If 0, fatal errors only appear in debug # messages (if debug >= 0). If > 0, errors # are passed to the caller as exceptions. diff --git a/Misc/NEWS b/Misc/NEWS index d3b26a4e0f7..dee6df416d9 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -157,6 +157,9 @@ C-API Library ------- +- Issue #7357: tarfile no longer suppresses fatal extraction errors by + default. + - Issue #5949: added check for correct lineends in input from IMAP server in imaplib.