From 33d144aa36ee8afb2f9a8c0b081e6f24591106ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristj=C3=A1n=20Valur=20J=C3=B3nsson?= Date: Wed, 3 Nov 2010 13:57:00 +0000 Subject: [PATCH] issue 9981 let make_buildinfo use a temporary directory on windows --- PCbuild/make_buildinfo.c | 42 ++++++++++++++++++------ PCbuild/make_buildinfo.vcproj | 61 ----------------------------------- PCbuild/pythoncore.vcproj | 32 +++++++++--------- 3 files changed, 48 insertions(+), 87 deletions(-) diff --git a/PCbuild/make_buildinfo.c b/PCbuild/make_buildinfo.c index 5a3d385227e..a41aac59b8c 100644 --- a/PCbuild/make_buildinfo.c +++ b/PCbuild/make_buildinfo.c @@ -19,9 +19,15 @@ invoked as a pre-link step for pythoncore, so that overwrites any previous getbuildinfo.o. + However, if a second argument is provided, this will be used + as a temporary directory where any getbuildinfo2.c and + getbuildinfo.o files are put. This is useful if multiple + configurations are being built in parallel, to avoid them + trampling each other's files. + */ -int make_buildinfo2() +int make_buildinfo2(const char *tmppath) { struct _stat st; HKEY hTortoise; @@ -46,7 +52,9 @@ int make_buildinfo2() if (_stat(command+1, &st) < 0) /* subwcrev.exe not part of the release */ return 0; - strcat_s(command, CMD_SIZE, "\" .. ..\\Modules\\getbuildinfo.c getbuildinfo2.c"); + strcat_s(command, CMD_SIZE, "\" .. ..\\Modules\\getbuildinfo.c "); + strcat_s(command, CMD_SIZE, tmppath); + strcat_s(command, CMD_SIZE, "getbuildinfo2.c"); puts(command); fflush(stdout); if (system(command) < 0) return 0; @@ -55,10 +63,12 @@ int make_buildinfo2() int main(int argc, char*argv[]) { - char command[500] = "cl.exe -c -D_WIN32 -DUSE_DL_EXPORT -D_WINDOWS -DWIN32 -D_WINDLL "; + char command[CMD_SIZE] = "cl.exe -c -D_WIN32 -DUSE_DL_EXPORT -D_WINDOWS -DWIN32 -D_WINDLL "; + char tmppath[CMD_SIZE] = ""; int do_unlink, result; - if (argc != 2) { - fprintf(stderr, "make_buildinfo $(ConfigurationName)\n"); + char *tmpdir = NULL; + if (argc <= 2 || argc > 3) { + fprintf(stderr, "make_buildinfo $(ConfigurationName) [tmpdir]\n"); return EXIT_FAILURE; } if (strcmp(argv[1], "Release") == 0) { @@ -78,16 +88,28 @@ int main(int argc, char*argv[]) fprintf(stderr, "unsupported configuration %s\n", argv[1]); return EXIT_FAILURE; } + if (argc > 2) { + tmpdir = argv[2]; + strcat_s(tmppath, _countof(tmppath), tmpdir); + strcat_s(tmppath, _countof(tmppath), "\\"); + } - if ((do_unlink = make_buildinfo2())) + if ((do_unlink = make_buildinfo2(tmppath))) { + strcat_s(command, CMD_SIZE, tmppath); strcat_s(command, CMD_SIZE, "getbuildinfo2.c -DSUBWCREV "); - else + } else strcat_s(command, CMD_SIZE, "..\\Modules\\getbuildinfo.c"); - strcat_s(command, CMD_SIZE, " -Fogetbuildinfo.o -I..\\Include -I..\\PC"); + strcat_s(command, CMD_SIZE, " -Fo"); + strcat_s(command, CMD_SIZE, tmppath); + strcat_s(command, CMD_SIZE, "getbuildinfo.o -I..\\Include -I..\\PC"); puts(command); fflush(stdout); result = system(command); - if (do_unlink) - _unlink("getbuildinfo2.c"); + if (do_unlink) { + command[0] = '\0'; + strcat_s(command, CMD_SIZE, tmppath); + strcat_s(command, CMD_SIZE, "getbuildinfo2.c"); + _unlink(command); + } if (result < 0) return EXIT_FAILURE; return 0; diff --git a/PCbuild/make_buildinfo.vcproj b/PCbuild/make_buildinfo.vcproj index c42229c1a0a..e494d93b0e3 100644 --- a/PCbuild/make_buildinfo.vcproj +++ b/PCbuild/make_buildinfo.vcproj @@ -12,9 +12,6 @@ - @@ -84,64 +81,6 @@ Name="VCPostBuildEventTool" /> - - - - - - - - - - - - - - - - - - - diff --git a/PCbuild/pythoncore.vcproj b/PCbuild/pythoncore.vcproj index 77aa1e3b95f..f5d12a3fb4d 100644 --- a/PCbuild/pythoncore.vcproj +++ b/PCbuild/pythoncore.vcproj @@ -59,11 +59,11 @@