Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

gh-105375: Improve error handling in `zoneinfo` module (#105586) 

Fix bugs where exceptions could end up being overwritten
because of deferred error handling.

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
This commit is contained in:
Nikita Sobolev 2023-06-10 00:48:54 +03:00 committed by GitHub
parent 91441bf7cb
commit 33c92c4f15
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Misc/NEWS.d/next/Library/2023-06-09-21-11-28.gh-issue-105375.4Mxn7t.rst Normal file
View File

@ -0,0 +1 @@
Fix bugs in :mod:`zoneinfo` where exceptions could be overwritten.

19
Modules/_zoneinfo.c
View File

@ -694,14 +694,19 @@ zoneinfo_fromutc(PyObject *obj_self, PyObject *dt)
}
else {
PyObject *replace = PyObject_GetAttrString(tmp, "replace");
PyObject *args = PyTuple_New(0);
PyObject *kwargs = PyDict_New();
Py_DECREF(tmp);
if (args == NULL || kwargs == NULL || replace == NULL) {
Py_XDECREF(args);
Py_XDECREF(kwargs);
Py_XDECREF(replace);
if (replace == NULL) {
return NULL;
}
PyObject *args = PyTuple_New(0);
if (args == NULL) {
Py_DECREF(replace);
return NULL;
}
PyObject *kwargs = PyDict_New();
if (kwargs == NULL) {
Py_DECREF(replace);
Py_DECREF(args);
return NULL;
}