bpo-44168: Fix error message in the parser for keyword arguments for invalid expressions (GH-26210)

Grammar/python.gram

@@ -843,7 +843,7 @@ invalid_arguments:
         RAISE_SYNTAX_ERROR_KNOWN_RANGE(a, asdl_seq_GET(b, b->size-1)->target, "Generator expression must be parenthesized") }
     | a=args ',' args { _PyPegen_arguments_parsing_error(p, a) }
 invalid_kwarg:
-    | a=expression b='=' {
+    | !(NAME '=') a=expression b='=' {
         RAISE_SYNTAX_ERROR_KNOWN_RANGE(
             a, b, "expression cannot contain assignment, perhaps you meant \"==\"?") }
 

Lib/test/test_syntax.py

@@ -458,28 +458,33 @@ SyntaxError: expected ':'
 ...   290, 291, 292, 293, 294, 295, 296, 297, 298, 299)  # doctest: +ELLIPSIS
 (0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, ..., 297, 298, 299)
 
-# >>> f(lambda x: x[0] = 3)
+>>> f(lambda x: x[0] = 3)
-# Traceback (most recent call last):
+Traceback (most recent call last):
-# SyntaxError: expression cannot contain assignment, perhaps you meant "=="?
+SyntaxError: expression cannot contain assignment, perhaps you meant "=="?
+
+# Check that this error doesn't trigger for names:
+>>> f(a={x: for x in {}})
+Traceback (most recent call last):
+SyntaxError: invalid syntax
 
 The grammar accepts any test (basically, any expression) in the
 keyword slot of a call site.  Test a few different options.
 
-# >>> f(x()=2)
+>>> f(x()=2)
-# Traceback (most recent call last):
+Traceback (most recent call last):
-# SyntaxError: expression cannot contain assignment, perhaps you meant "=="?
+SyntaxError: expression cannot contain assignment, perhaps you meant "=="?
-# >>> f(a or b=1)
+>>> f(a or b=1)
-# Traceback (most recent call last):
+Traceback (most recent call last):
-# SyntaxError: expression cannot contain assignment, perhaps you meant "=="?
+SyntaxError: expression cannot contain assignment, perhaps you meant "=="?
-# >>> f(x.y=1)
+>>> f(x.y=1)
-# Traceback (most recent call last):
+Traceback (most recent call last):
-# SyntaxError: expression cannot contain assignment, perhaps you meant "=="?
+SyntaxError: expression cannot contain assignment, perhaps you meant "=="?
-# >>> f((x)=2)
+>>> f((x)=2)
-# Traceback (most recent call last):
+Traceback (most recent call last):
-# SyntaxError: expression cannot contain assignment, perhaps you meant "=="?
+SyntaxError: expression cannot contain assignment, perhaps you meant "=="?
-# >>> f(True=2)
+>>> f(True=2)
-# Traceback (most recent call last):
+Traceback (most recent call last):
-# SyntaxError: cannot assign to True here. Maybe you meant '==' instead of '='?
+SyntaxError: expression cannot contain assignment, perhaps you meant "=="?
 >>> f(__debug__=1)
 Traceback (most recent call last):
 SyntaxError: cannot assign to __debug__
@@ -1422,7 +1427,7 @@ def case(x):
 case(34)
 """
         compile(code, "<string>", "exec")
-    
+
     def test_multiline_compiler_error_points_to_the_end(self):
         self._check_error(
             "call(\na=1,\na=1\n)",

Misc/NEWS.d/next/Core and Builtins/2021-05-18-11-27-02.bpo-44168.mgB-rt.rst

@@ -0,0 +1,2 @@
+Fix error message in the parser involving keyword arguments with invalid
+expressions. Patch by Pablo Galindo