Fix for raising exception not derived from BaseException in _SelectorSslTransport.resume_reading

This commit is contained in:
Andrew Svetlov 2014-05-27 21:24:43 +03:00
parent 0a4d13e87e
commit 3207a03035
2 changed files with 5 additions and 1 deletions

View File

@ -670,7 +670,7 @@ class _SelectorSslTransport(_SelectorTransport):
def resume_reading(self): def resume_reading(self):
if not self._paused: if not self._paused:
raise ('Not paused') raise RuntimeError('Not paused')
self._paused = False self._paused = False
if self._closing: if self._closing:
return return

View File

@ -711,6 +711,8 @@ class SelectorSocketTransportTests(unittest.TestCase):
tr.resume_reading() tr.resume_reading()
self.assertFalse(tr._paused) self.assertFalse(tr._paused)
self.loop.assert_reader(7, tr._read_ready) self.loop.assert_reader(7, tr._read_ready)
with self.assertRaises(RuntimeError):
tr.resume_reading()
def test_read_ready(self): def test_read_ready(self):
transport = _SelectorSocketTransport( transport = _SelectorSocketTransport(
@ -1125,6 +1127,8 @@ class SelectorSslTransportTests(unittest.TestCase):
tr.resume_reading() tr.resume_reading()
self.assertFalse(tr._paused) self.assertFalse(tr._paused)
self.loop.assert_reader(1, tr._read_ready) self.loop.assert_reader(1, tr._read_ready)
with self.assertRaises(RuntimeError):
tr.resume_reading()
def test_write(self): def test_write(self):
transport = self._make_one() transport = self._make_one()