Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Issue #13014: Fix a possible reference leak in SSLSocket.getpeercert().

This commit is contained in:
Antoine Pitrou 2012-02-15 22:25:27 +01:00
parent 1ca93954e1
commit 2f5a163dfc
2 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Misc/NEWS
View File

@ -116,6 +116,8 @@ Core and Builtins
Library
-------
- Issue #13014: Fix a possible reference leak in SSLSocket.getpeercert().
- Issue #13015: Fix a possible reference leak in defaultdict.__repr__.
Patch by Suman Saha.

23
Modules/_ssl.c
View File

@ -519,15 +519,20 @@ _create_tuple_for_X509_NAME (X509_NAME *xname)
goto fail1;
}
/* now, there's typically a dangling RDN */
if ((rdn != NULL) && (PyList_Size(rdn) > 0)) {
rdnt = PyList_AsTuple(rdn);
Py_DECREF(rdn);
if (rdnt == NULL)
goto fail0;
retcode = PyList_Append(dn, rdnt);
Py_DECREF(rdnt);
if (retcode < 0)
goto fail0;
if (rdn != NULL) {
if (PyList_GET_SIZE(rdn) > 0) {
rdnt = PyList_AsTuple(rdn);
Py_DECREF(rdn);
if (rdnt == NULL)
goto fail0;
retcode = PyList_Append(dn, rdnt);
Py_DECREF(rdnt);
if (retcode < 0)
goto fail0;
}
else {
Py_DECREF(rdn);
}
}
/* convert list to tuple */