Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

gh-123504: Fix regression in `_tkinter` initializer (#123662) 

* Add module traverse function to _tkinter.
* Set m_size to -1 (instead of 0).
This commit is contained in:
Peter Bierma 2024-09-04 07:43:50 -04:00 committed by GitHub
parent 0d6b6e34a2
commit 2daed5f7a7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Modules/_tkinter.c
View File

@ -3390,7 +3390,7 @@ DisableEventHook(void)
} }
static int static int
module_clear(PyObject *mod) module_clear(PyObject *Py_UNUSED(mod))
{ {
Py_CLEAR(Tkinter_TclError); Py_CLEAR(Tkinter_TclError);
Py_CLEAR(Tkapp_Type); Py_CLEAR(Tkapp_Type);
@ -3399,16 +3399,28 @@ module_clear(PyObject *mod)
return 0; return 0;
} }
static int
module_traverse(PyObject *Py_UNUSED(module), visitproc visit, void *arg)
{
Py_VISIT(Tkinter_TclError);
Py_VISIT(Tkapp_Type);
Py_VISIT(Tktt_Type);
Py_VISIT(PyTclObject_Type);
return 0;
}
static void static void
module_free(void *mod) module_free(void *mod)
{ {
module_clear((PyObject *)mod); (void)module_clear((PyObject *)mod);
} }
static struct PyModuleDef _tkintermodule = { static struct PyModuleDef _tkintermodule = {
PyModuleDef_HEAD_INIT, PyModuleDef_HEAD_INIT,
.m_name = "_tkinter", .m_name = "_tkinter",
.m_size = -1,
.m_methods = moduleMethods, .m_methods = moduleMethods,
.m_traverse = module_traverse,
.m_clear = module_clear, .m_clear = module_clear,
.m_free = module_free .m_free = module_free
}; };