bpo-46178: Remove/rename redundant Travis CI code (#30309)

This commit is contained in:
Hugo van Kemenade 2021-12-31 02:16:27 +02:00 committed by GitHub
parent 82c2b54a35
commit 2cf7d02b99
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 8 additions and 23 deletions

View File

@ -66,7 +66,7 @@ steps:
COMMAND: make COMMAND: make
- ${{ if eq(parameters.patchcheck, 'true') }}: - ${{ if eq(parameters.patchcheck, 'true') }}:
- script: ./python Tools/scripts/patchcheck.py --travis true - script: ./python Tools/scripts/patchcheck.py --ci true
displayName: 'Run patchcheck.py' displayName: 'Run patchcheck.py'
condition: and(succeeded(), eq(variables['Build.Reason'], 'PullRequest')) condition: and(succeeded(), eq(variables['Build.Reason'], 'PullRequest'))

View File

@ -72,8 +72,9 @@ test runner
a GUI tool for test discovery and execution. This is intended largely for ease of use a GUI tool for test discovery and execution. This is intended largely for ease of use
for those new to unit testing. For production environments it is for those new to unit testing. For production environments it is
recommended that tests be driven by a continuous integration system such as recommended that tests be driven by a continuous integration system such as
`Buildbot <https://buildbot.net/>`_, `Jenkins <https://jenkins.io/>`_ `Buildbot <https://buildbot.net/>`_, `Jenkins <https://jenkins.io/>`_,
or `Travis-CI <https://travis-ci.com>`_, or `AppVeyor <https://www.appveyor.com/>`_. `GitHub Actions <https://github.com/features/actions>`_, or
`AppVeyor <https://www.appveyor.com/>`_.
.. _unittest-minimal-example: .. _unittest-minimal-example:

View File

@ -28,13 +28,6 @@ def _wrap_with_retry_thrice(func, exc):
return _retry_thrice(func, exc, *args, **kwargs) return _retry_thrice(func, exc, *args, **kwargs)
return wrapped return wrapped
# bpo-35411: FTP tests of test_urllib2net randomly fail
# with "425 Security: Bad IP connecting" on Travis CI
skip_ftp_test_on_travis = unittest.skipIf('TRAVIS' in os.environ,
'bpo-35411: skip FTP test '
'on Travis CI')
# Connecting to remote hosts is flaky. Make it more robust by retrying # Connecting to remote hosts is flaky. Make it more robust by retrying
# the connection several times. # the connection several times.
_urlopen_with_retry = _wrap_with_retry_thrice(urllib.request.urlopen, _urlopen_with_retry = _wrap_with_retry_thrice(urllib.request.urlopen,
@ -139,7 +132,6 @@ class OtherNetworkTests(unittest.TestCase):
# XXX The rest of these tests aren't very good -- they don't check much. # XXX The rest of these tests aren't very good -- they don't check much.
# They do sometimes catch some major disasters, though. # They do sometimes catch some major disasters, though.
@skip_ftp_test_on_travis
def test_ftp(self): def test_ftp(self):
urls = [ urls = [
'ftp://www.pythontest.net/README', 'ftp://www.pythontest.net/README',
@ -339,7 +331,6 @@ class TimeoutTest(unittest.TestCase):
FTP_HOST = 'ftp://www.pythontest.net/' FTP_HOST = 'ftp://www.pythontest.net/'
@skip_ftp_test_on_travis
def test_ftp_basic(self): def test_ftp_basic(self):
self.assertIsNone(socket.getdefaulttimeout()) self.assertIsNone(socket.getdefaulttimeout())
with socket_helper.transient_internet(self.FTP_HOST, timeout=None): with socket_helper.transient_internet(self.FTP_HOST, timeout=None):
@ -347,7 +338,6 @@ class TimeoutTest(unittest.TestCase):
self.addCleanup(u.close) self.addCleanup(u.close)
self.assertIsNone(u.fp.fp.raw._sock.gettimeout()) self.assertIsNone(u.fp.fp.raw._sock.gettimeout())
@skip_ftp_test_on_travis
def test_ftp_default_timeout(self): def test_ftp_default_timeout(self):
self.assertIsNone(socket.getdefaulttimeout()) self.assertIsNone(socket.getdefaulttimeout())
with socket_helper.transient_internet(self.FTP_HOST): with socket_helper.transient_internet(self.FTP_HOST):
@ -359,7 +349,6 @@ class TimeoutTest(unittest.TestCase):
socket.setdefaulttimeout(None) socket.setdefaulttimeout(None)
self.assertEqual(u.fp.fp.raw._sock.gettimeout(), 60) self.assertEqual(u.fp.fp.raw._sock.gettimeout(), 60)
@skip_ftp_test_on_travis
def test_ftp_no_timeout(self): def test_ftp_no_timeout(self):
self.assertIsNone(socket.getdefaulttimeout()) self.assertIsNone(socket.getdefaulttimeout())
with socket_helper.transient_internet(self.FTP_HOST): with socket_helper.transient_internet(self.FTP_HOST):
@ -371,7 +360,6 @@ class TimeoutTest(unittest.TestCase):
socket.setdefaulttimeout(None) socket.setdefaulttimeout(None)
self.assertIsNone(u.fp.fp.raw._sock.gettimeout()) self.assertIsNone(u.fp.fp.raw._sock.gettimeout())
@skip_ftp_test_on_travis
def test_ftp_timeout(self): def test_ftp_timeout(self):
with socket_helper.transient_internet(self.FTP_HOST): with socket_helper.transient_internet(self.FTP_HOST):
u = _urlopen_with_retry(self.FTP_HOST, timeout=60) u = _urlopen_with_retry(self.FTP_HOST, timeout=60)

View File

@ -1,10 +1,6 @@
This is Python version 3.11.0 alpha 3 This is Python version 3.11.0 alpha 3
===================================== =====================================
.. image:: https://travis-ci.com/python/cpython.svg?branch=main
:alt: CPython build status on Travis CI
:target: https://travis-ci.com/python/cpython
.. image:: https://github.com/python/cpython/workflows/Tests/badge.svg .. image:: https://github.com/python/cpython/workflows/Tests/badge.svg
:alt: CPython build status on GitHub Actions :alt: CPython build status on GitHub Actions
:target: https://github.com/python/cpython/actions :target: https://github.com/python/cpython/actions

View File

@ -245,7 +245,7 @@ def regenerated_pyconfig_h_in(file_paths):
else: else:
return "not needed" return "not needed"
def travis(pull_request): def ci(pull_request):
if pull_request == 'false': if pull_request == 'false':
print('Not a pull request; skipping') print('Not a pull request; skipping')
return return
@ -301,10 +301,10 @@ def main():
if __name__ == '__main__': if __name__ == '__main__':
import argparse import argparse
parser = argparse.ArgumentParser(description=__doc__) parser = argparse.ArgumentParser(description=__doc__)
parser.add_argument('--travis', parser.add_argument('--ci',
help='Perform pass/fail checks') help='Perform pass/fail checks')
args = parser.parse_args() args = parser.parse_args()
if args.travis: if args.ci:
travis(args.travis) ci(args.ci)
else: else:
main() main()