Modified the Py_RETURN_* macros by having the statements surrounded by {} in

order to prevent any unexpected surprises from someone using them in a
conditional without using curly braces (e.g., ``if (foo) Py_RETURN_TRUE``.
This commit is contained in:
Brett Cannon 2003-10-19 21:31:43 +00:00
parent d05235ec49
commit 26b3a7b82c
3 changed files with 6 additions and 3 deletions

View File

@ -24,8 +24,8 @@ PyAPI_DATA(PyIntObject) _Py_ZeroStruct, _Py_TrueStruct;
#define Py_True ((PyObject *) &_Py_TrueStruct)
/* Macros for returning Py_True or Py_False, respectively */
#define Py_RETURN_TRUE Py_INCREF(Py_True); return Py_True;
#define Py_RETURN_FALSE Py_INCREF(Py_False); return Py_False;
#define Py_RETURN_TRUE {Py_INCREF(Py_True); return Py_True;}
#define Py_RETURN_FALSE {Py_INCREF(Py_False); return Py_False;}
/* Function to return a bool from a C long */
PyAPI_FUNC(PyObject *) PyBool_FromLong(long);

View File

@ -634,7 +634,7 @@ PyAPI_DATA(PyObject) _Py_NoneStruct; /* Don't use this directly */
#define Py_None (&_Py_NoneStruct)
/* Macro for returning Py_None from a function */
#define Py_RETURN_NONE Py_INCREF(Py_None); return Py_None;
#define Py_RETURN_NONE {Py_INCREF(Py_None); return Py_None;}
/*
Py_NotImplemented is a singleton used to signal that an operation is

View File

@ -155,6 +155,9 @@ Build
C API
-----
- Added three new macros: Py_RETURN_NONE, Py_RETURN_TRUE, and Py_RETURN_FALSE.
Each return the singleton they mention after Py_INCREF()ing them.
- Added a new function, PyTuple_Pack(n, ...) for constructing tuples from a
variable length argument list of Python objects without having to invoke
the more complex machinery of Py_BuildValue(). PyTuple_Pack(3, a, b, c)