Bug #1339007: Shelf objects now don't raise an exception in their

__del__ method when initialization failed.
2006-06-14 06:08:31 +00:00 · 2006-06-14 06:08:31 +00:00 · 2605ca8773
parent d825143be1
commit 2605ca8773
2 changed files with 6 additions and 0 deletions
--- a/Lib/shelve.py
+++ b/Lib/shelve.py
@ -139,6 +139,9 @@ class Shelf(UserDict.DictMixin):
        self.dict = 0

    def __del__(self):
+        if not hasattr(self, 'writeback'):
+            # __init__ didn't succeed, so don't bother closing
+            return
        self.close()

    def sync(self):
--- a/Misc/NEWS
+++ b/Misc/NEWS
@ -156,6 +156,9 @@ Extension Modules
 Library
 -------

+- Bug #1339007: Shelf objects now don't raise an exception in their
+  __del__ method when initialization failed.
+
 - Patch #1455898: The MBCS codec now supports the incremental mode for
  double-byte encodings.