Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Issue #17901: fix TreeBuilder construction for an explicit element_factory=None 

Based on report and patch by Aaron Oakley.
This commit is contained in:
Eli Bendersky 2013-05-18 15:47:58 -07:00
parent 10e8c49a11 08231a9c6a
commit 20c1cdd64a
3 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Lib/test/test_xml_etree.py
View File

@ -1896,6 +1896,12 @@ class TreeBuilderTest(unittest.TestCase):
parser.feed(self.sample1)
self.assertIsNone(parser.close())
def test_treebuilder_elementfactory_none(self):
parser = ET.XMLParser(target=ET.TreeBuilder(element_factory=None))
parser.feed(self.sample1)
e = parser.close()
self._check_sample1_element(e)
def test_subclass(self):
class MyTreeBuilder(ET.TreeBuilder):
def foobar(self, x):

1
Misc/ACKS
View File

@ -905,6 +905,7 @@ John O'Connor
Kevin O'Connor
Tim O'Malley
Zooko O'Whielacronx
Aaron Oakley
James Oakley
Jon Oberheide
Pascal Oberndoerfer

2
Modules/_elementtree.c
View File

@ -2341,7 +2341,7 @@ treebuilder_handle_start(TreeBuilderObject* self, PyObject* tag,
self->data = NULL;
}
if (self->element_factory) {
if (self->element_factory && self->element_factory != Py_None) {
node = PyObject_CallFunction(self->element_factory, "OO", tag, attrib);
} else {
node = create_new_element(tag, attrib);