From 205e75bb629408d850efd6659c87ba1f8512b44b Mon Sep 17 00:00:00 2001 From: Serhiy Storchaka Date: Wed, 24 Feb 2016 12:05:50 +0200 Subject: [PATCH] Issue #25913: Leading <~ is optional now in base64.a85decode() with adobe=True. Patch by Swati Jaiswal. --- Lib/base64.py | 13 +++++++++---- Lib/test/test_base64.py | 3 +-- Misc/NEWS | 3 +++ 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/Lib/base64.py b/Lib/base64.py index e2c597b0ca6..adaec1de61b 100755 --- a/Lib/base64.py +++ b/Lib/base64.py @@ -367,10 +367,15 @@ def a85decode(b, *, foldspaces=False, adobe=False, ignorechars=b' \t\n\r\v'): """ b = _bytes_from_decode_data(b) if adobe: - if not (b.startswith(_A85START) and b.endswith(_A85END)): - raise ValueError("Ascii85 encoded byte sequences must be bracketed " - "by {!r} and {!r}".format(_A85START, _A85END)) - b = b[2:-2] # Strip off start/end markers + if not b.endswith(_A85END): + raise ValueError( + "Ascii85 encoded byte sequences must end " + "with {!r}".format(_A85END) + ) + if b.startswith(_A85START): + b = b[2:-2] # Strip off start/end markers + else: + b = b[:-2] # # We have to go through this stepwise, so as to ignore spaces and handle # special short sequences diff --git a/Lib/test/test_base64.py b/Lib/test/test_base64.py index 9b853a854b3..4f86aaa0c0e 100644 --- a/Lib/test/test_base64.py +++ b/Lib/test/test_base64.py @@ -494,6 +494,7 @@ class BaseXYTestCase(unittest.TestCase): eq(base64.a85decode(data, adobe=False), res, data) eq(base64.a85decode(data.decode("ascii"), adobe=False), res, data) eq(base64.a85decode(b'<~' + data + b'~>', adobe=True), res, data) + eq(base64.a85decode(data + b'~>', adobe=True), res, data) eq(base64.a85decode('<~%s~>' % data.decode("ascii"), adobe=True), res, data) @@ -584,8 +585,6 @@ class BaseXYTestCase(unittest.TestCase): b"malformed", adobe=True) self.assertRaises(ValueError, base64.a85decode, b"<~still malformed", adobe=True) - self.assertRaises(ValueError, base64.a85decode, - b"also malformed~>", adobe=True) # With adobe=False (the default), Adobe framing markers are disallowed self.assertRaises(ValueError, base64.a85decode, diff --git a/Misc/NEWS b/Misc/NEWS index c47ca608257..fd4ca59277c 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -76,6 +76,9 @@ Core and Builtins Library ------- +- Issue #25913: Leading ``<~`` is optional now in base64.a85decode() with + adobe=True. Patch by Swati Jaiswal. + - Issue #26186: Remove an invalid type check in importlib.util.LazyLoader. - Issue #26367: importlib.__import__() raises SystemError like