Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

bpo-34720: Fix test_importlib.test_bad_traverse for AIX (GH-9391) 

Fix  Modules/_testmultiphase.c so that it exits with non-zero status on AIX just as other systems do (non zero exit status, e.g. as result of a segmentation fault) when a NULL pointer is accessed for data.


https://bugs.python.org/issue34720
This commit is contained in:
Michael Felt 2019-02-17 13:02:56 +01:00 committed by Miss Islington (bot)
parent 414c625a7e
commit 1bf8845f74
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Misc/NEWS.d/next/Tests/2018-12-26-12-31-16.bpo-34720.T268vz.rst Normal file
View File

@ -0,0 +1,2 @@
Assert m_state != NULL to mimic GC traversal functions that do not correctly
handle module creation when the module state has not been created.

8
Modules/_testmultiphase.c
View File

@ -624,6 +624,14 @@ bad_traverse(PyObject *self, visitproc visit, void *arg) {
testmultiphase_state *m_state; testmultiphase_state *m_state;
m_state = PyModule_GetState(self); m_state = PyModule_GetState(self);
/* The following assertion mimics any traversal function that doesn't correctly handle
* the case during module creation where the module state hasn't been created yet.
*
* The check that it is used to test only runs in debug mode, so it is OK that the
* assert() will get compiled out in fully optimised release builds.
*/
assert(m_state != NULL);
Py_VISIT(m_state->integer); Py_VISIT(m_state->integer);
return 0; return 0;
} }