Change parameter name from *x* for reals to *n* for integers. (GH-32377)

This commit is contained in:
Raymond Hettinger 2022-04-06 14:35:05 -05:00 committed by GitHub
parent 32b33879c2
commit 1ba82d4419
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 8 deletions

View File

@ -66,9 +66,9 @@ Number-theoretic and representation functions
Return the absolute value of *x*.
.. function:: factorial(x)
.. function:: factorial(n)
Return *x* factorial as an integer. Raises :exc:`ValueError` if *x* is not integral or
Return *n* factorial as an integer. Raises :exc:`ValueError` if *n* is not integral or
is negative.
.. deprecated:: 3.9

View File

@ -45,10 +45,10 @@ PyDoc_STRVAR(math_isqrt__doc__,
{"isqrt", (PyCFunction)math_isqrt, METH_O, math_isqrt__doc__},
PyDoc_STRVAR(math_factorial__doc__,
"factorial($module, x, /)\n"
"factorial($module, n, /)\n"
"--\n"
"\n"
"Find x!.\n"
"Find n!.\n"
"\n"
"Raise a ValueError if x is negative or non-integral.");
@ -865,4 +865,4 @@ math_ulp(PyObject *module, PyObject *arg)
exit:
return return_value;
}
/*[clinic end generated code: output=1eae2b3ef19568fa input=a9049054013a1b77]*/
/*[clinic end generated code: output=6381e7d982ff3711 input=a9049054013a1b77]*/

View File

@ -2093,17 +2093,17 @@ static const unsigned long SmallFactorials[] = {
/*[clinic input]
math.factorial
x as arg: object
n as arg: object
/
Find x!.
Find n!.
Raise a ValueError if x is negative or non-integral.
[clinic start generated code]*/
static PyObject *
math_factorial(PyObject *module, PyObject *arg)
/*[clinic end generated code: output=6686f26fae00e9ca input=6d1c8105c0d91fb4]*/
/*[clinic end generated code: output=6686f26fae00e9ca input=713fb771677e8c31]*/
{
long x, two_valuation;
int overflow;