Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Forgot to return NULL in joinfields() when a type error was detected 

in one of the sequence items.
This commit is contained in:
Guido van Rossum 1998-02-06 22:37:12 +00:00
parent 64608cfb86
commit 1ad1b3f911
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Modules/stropmodule.c
View File

@ -225,9 +225,11 @@ strop_joinfields(self, args)
if (seqlen == 1) {
/* Optimization if there's only one item */
PyObject *item = PySequence_GetItem(seq, 0);
if (item && !PyString_Check(item))
if (item && !PyString_Check(item)) {
PyErr_SetString(PyExc_TypeError,
"first argument must be sequence of strings");
return NULL;
}
return item;
}