Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

gh-105800: Issue SyntaxWarning in f-strings for invalid escape sequences (#105801)

This commit is contained in:
Pablo Galindo Salgado 2023-06-15 01:08:12 +01:00 committed by GitHub
parent 698a0da7d4
commit 12b6d844d8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Lib/test/test_fstring.py
View File

@ -907,6 +907,9 @@ x = (
with self.assertWarns(DeprecationWarning): # invalid escape sequence with self.assertWarns(DeprecationWarning): # invalid escape sequence
value = eval(r"f'\{6*7}'") value = eval(r"f'\{6*7}'")
self.assertEqual(value, '\\42') self.assertEqual(value, '\\42')
with self.assertWarns(SyntaxWarning): # invalid escape sequence
value = eval(r"f'\g'")
self.assertEqual(value, '\\g')
self.assertEqual(f'\\{6*7}', '\\42') self.assertEqual(f'\\{6*7}', '\\42')
self.assertEqual(fr'\{6*7}', '\\42') self.assertEqual(fr'\{6*7}', '\\42')

2
Misc/NEWS.d/next/Core and Builtins/2023-06-14-22-52-06.gh-issue-105800.hdpPzZ.rst Normal file
View File

@ -0,0 +1,2 @@
Correctly issue :exc:`SyntaxWarning` in f-strings if invalid sequences are
used. Patch by Pablo Galindo

6
Parser/action_helpers.c
View File

@ -1225,7 +1225,7 @@ _PyPegen_nonparen_genexp_in_call(Parser *p, expr_ty args, asdl_comprehension_seq
// Fstring stuff // Fstring stuff
static expr_ty static expr_ty
_PyPegen_decode_fstring_part(Parser* p, int is_raw, expr_ty constant) { _PyPegen_decode_fstring_part(Parser* p, int is_raw, expr_ty constant, Token* token) {
assert(PyUnicode_CheckExact(constant->v.Constant.value)); assert(PyUnicode_CheckExact(constant->v.Constant.value));
const char* bstr = PyUnicode_AsUTF8(constant->v.Constant.value); const char* bstr = PyUnicode_AsUTF8(constant->v.Constant.value);
@ -1241,7 +1241,7 @@ _PyPegen_decode_fstring_part(Parser* p, int is_raw, expr_ty constant) {
} }
is_raw = is_raw || strchr(bstr, '\\') == NULL; is_raw = is_raw || strchr(bstr, '\\') == NULL;
PyObject *str = _PyPegen_decode_string(p, is_raw, bstr, len, NULL); PyObject *str = _PyPegen_decode_string(p, is_raw, bstr, len, token);
if (str == NULL) { if (str == NULL) {
_Pypegen_raise_decode_error(p); _Pypegen_raise_decode_error(p);
return NULL; return NULL;
@ -1315,7 +1315,7 @@ _PyPegen_joined_str(Parser *p, Token* a, asdl_expr_seq* raw_expressions, Token*b
for (Py_ssize_t i = 0; i < n_items; i++) { for (Py_ssize_t i = 0; i < n_items; i++) {
expr_ty item = asdl_seq_GET(expr, i); expr_ty item = asdl_seq_GET(expr, i);
if (item->kind == Constant_kind) { if (item->kind == Constant_kind) {
item = _PyPegen_decode_fstring_part(p, is_raw, item); item = _PyPegen_decode_fstring_part(p, is_raw, item, b);
if (item == NULL) { if (item == NULL) {
return NULL; return NULL;
} }