mirror of https://github.com/python/cpython
Warn against replacing PyNumber_Add with PyNumber_InPlaceAdd in sum
This commit is contained in:
parent
828b39865a
commit
0e0e215308
|
@ -2350,6 +2350,15 @@ builtin_sum(PyObject *self, PyObject *args)
|
||||||
}
|
}
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
/* It's tempting to use PyNumber_InPlaceAdd instead of
|
||||||
|
PyNumber_Add here, to avoid quadratic running time
|
||||||
|
when doing 'sum(list_of_lists, [])'. However, this
|
||||||
|
would produce a change in behaviour: a snippet like
|
||||||
|
|
||||||
|
empty = []
|
||||||
|
sum([[x] for x in range(10)], empty)
|
||||||
|
|
||||||
|
would change the value of empty. */
|
||||||
temp = PyNumber_Add(result, item);
|
temp = PyNumber_Add(result, item);
|
||||||
Py_DECREF(result);
|
Py_DECREF(result);
|
||||||
Py_DECREF(item);
|
Py_DECREF(item);
|
||||||
|
|
Loading…
Reference in New Issue