Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

gh-109748: Fix again venv test_zippath_from_non_installed_posix() (#110149) 

Call also copy_python_src_ignore() on listdir() names.

shutil.copytree(): replace set() with an empty tuple. An empty tuple
becomes a constant in the compiler and checking if an item is in an
empty tuple is cheap.
This commit is contained in:
Victor Stinner 2023-09-30 20:23:26 +02:00 committed by GitHub
parent 74e425ec18
commit 0def8c712b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/shutil.py
View File

@ -481,7 +481,7 @@ def _copytree(entries, src, dst, symlinks, ignore, copy_function,
if ignore is not None: if ignore is not None:
ignored_names = ignore(os.fspath(src), [x.name for x in entries]) ignored_names = ignore(os.fspath(src), [x.name for x in entries])
else: else:
ignored_names = set() ignored_names = ()
os.makedirs(dst, exist_ok=dirs_exist_ok) os.makedirs(dst, exist_ok=dirs_exist_ok)
errors = [] errors = []

2
Lib/test/test_support.py
View File

@ -832,7 +832,7 @@ class TestSupport(unittest.TestCase):
self.assertEqual(support.copy_python_src_ignore(path, os.listdir(path)), self.assertEqual(support.copy_python_src_ignore(path, os.listdir(path)),
ignored | {'build', 'venv'}) ignored | {'build', 'venv'})
# An other directory # Another directory
path = os.path.join(src_dir, 'Objects') path = os.path.join(src_dir, 'Objects')
self.assertEqual(support.copy_python_src_ignore(path, os.listdir(path)), self.assertEqual(support.copy_python_src_ignore(path, os.listdir(path)),
ignored) ignored)

6
Lib/test/test_venv.py
View File

@ -569,7 +569,11 @@ class BasicTest(BaseTest):
eachpath, eachpath,
os.path.join(non_installed_dir, platlibdir)) os.path.join(non_installed_dir, platlibdir))
elif os.path.isfile(os.path.join(eachpath, "os.py")): elif os.path.isfile(os.path.join(eachpath, "os.py")):
for name in os.listdir(eachpath): names = os.listdir(eachpath)
ignored_names = copy_python_src_ignore(eachpath, names)
for name in names:
if name in ignored_names:
continue
if name == "site-packages": if name == "site-packages":
continue continue
fn = os.path.join(eachpath, name) fn = os.path.join(eachpath, name)