Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Release the GIL during COM method calls, to avoid deadlocks in 

Python coded COM objects.
This commit is contained in:
Thomas Heller 2006-06-11 17:04:22 +00:00
parent 0e0c9f4740
commit 0d5d222959
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Modules/_ctypes/callproc.c
View File

@ -804,14 +804,20 @@ GetComError(HRESULT errcode, GUID *riid, IUnknown *pIunk)
PyObject *obj;
TCHAR *text;
/* We absolutely have to release the GIL during COM method calls,
otherwise we may get a deadlock!
*/
Py_BEGIN_ALLOW_THREADS
hr = pIunk->lpVtbl->QueryInterface(pIunk, &IID_ISupportErrorInfo, (void **)&psei);
if (FAILED(hr))
goto failed;
hr = psei->lpVtbl->InterfaceSupportsErrorInfo(psei, riid);
psei->lpVtbl->Release(psei);
if (FAILED(hr))
goto failed;
hr = GetErrorInfo(0, &pei);
if (hr != S_OK)
goto failed;
@ -822,9 +828,10 @@ GetComError(HRESULT errcode, GUID *riid, IUnknown *pIunk)
pei->lpVtbl->GetHelpFile(pei, &helpfile);
pei->lpVtbl->GetSource(pei, &source);
pei->lpVtbl->Release(pei);
failed:
if (pei)
pei->lpVtbl->Release(pei);
Py_END_ALLOW_THREADS
progid = NULL;
ProgIDFromCLSID(&guid, &progid);