Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

gh-123017: Add Android to the list of platforms where `strftime` doesn't support negative years (#124467) 

Add Android to the list of platforms where `strftime` doesn't support negative years
This commit is contained in:
Malcolm Smith 2024-09-27 15:35:18 +01:00 committed by GitHub
parent 365dffbaad
commit 0a3577bdfc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Lib/test/test_time.py
View File

@ -654,8 +654,7 @@ class _TestStrftimeYear:
self.test_year('%04d', func=year4d) self.test_year('%04d', func=year4d)
def skip_if_not_supported(y): def skip_if_not_supported(y):
msg = "strftime() is limited to [1; 9999] with Visual Studio" msg = f"strftime() does not support year {y} on this platform"
# Check that it doesn't crash for year > 9999
try: try:
time.strftime('%Y', (y,) + (0,) * 8) time.strftime('%Y', (y,) + (0,) * 8)
except ValueError: except ValueError:

2
Misc/NEWS.d/next/Library/2024-09-24-21-15-27.gh-issue-123017.dSAr2f.rst Normal file
View File

@ -0,0 +1,2 @@
Due to unreliable results on some devices, :func:`time.strftime` no longer
accepts negative years on Android.

7
Modules/timemodule.c
View File

@ -813,7 +813,12 @@ time_strftime(PyObject *module, PyObject *args)
return NULL; return NULL;
} }
#if defined(_MSC_VER) || (defined(__sun) && defined(__SVR4)) || defined(_AIX) || defined(__VXWORKS__) // Some platforms only support a limited range of years.
//
// Android works with negative years on the emulator, but fails on some
// physical devices (#123017).
#if defined(_MSC_VER) || (defined(__sun) && defined(__SVR4)) || defined(_AIX) \
|| defined(__VXWORKS__) || defined(__ANDROID__)
if (buf.tm_year + 1900 < 1 || 9999 < buf.tm_year + 1900) { if (buf.tm_year + 1900 < 1 || 9999 < buf.tm_year + 1900) {
PyErr_SetString(PyExc_ValueError, PyErr_SetString(PyExc_ValueError,
"strftime() requires year in [1; 9999]"); "strftime() requires year in [1; 9999]");