From 089835469d5efbea4793cd611b43cb8387f2e7e5 Mon Sep 17 00:00:00 2001 From: Vinay Sajip Date: Tue, 2 Jul 2024 18:57:34 +0100 Subject: [PATCH] gh-121035: Further improve logging flow diagram with respect to dark/light modes. (GH-121265) --- Doc/howto/logging.rst | 6 ++++-- Doc/howto/logging_flow.svg | 10 ++++++++++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/Doc/howto/logging.rst b/Doc/howto/logging.rst index 9c55233e910..cbfe93319dd 100644 --- a/Doc/howto/logging.rst +++ b/Doc/howto/logging.rst @@ -403,11 +403,13 @@ following diagram. function updateBody(theme) { let elem = document.body; + elem.classList.remove('dark-theme'); + elem.classList.remove('light-theme'); if (theme === 'dark') { elem.classList.add('dark-theme'); } - else { - elem.classList.remove('dark-theme'); + else if (theme === 'light') { + elem.classList.add('light-theme'); } } diff --git a/Doc/howto/logging_flow.svg b/Doc/howto/logging_flow.svg index 9807323b719..4974994ac6b 100644 --- a/Doc/howto/logging_flow.svg +++ b/Doc/howto/logging_flow.svg @@ -46,6 +46,7 @@ filter: invert(100%) hue-rotate(180deg) saturate(1.25); } } + /* These rules are for when the theme selector is used, perhaps in contrast to the browser theme. */ body.dark-theme polygon, body.dark-theme rect, body.dark-theme polyline, body.dark-theme line { stroke: #ffffff; } @@ -55,6 +56,15 @@ body.dark-theme text { fill: #ffffff; } + body.light-theme polygon, body.light-theme rect, body.light-theme polyline, body.light-theme line { + stroke: #000000; + } + body.light-theme polygon.filled { + fill: #000000; + } + body.light-theme text { + fill: #000000; + }