From 4f35079858695e4d74a82a304332f70a0aa98e92 Mon Sep 17 00:00:00 2001 From: Richard Oudkerk Date: Sun, 13 Oct 2013 00:49:27 +0100 Subject: [PATCH] Make test_terminate() succeed or fail quickly. This does not fix #19227, but should stop the Gentoo buildbot from hanging. --- Lib/test/test_multiprocessing.py | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/Lib/test/test_multiprocessing.py b/Lib/test/test_multiprocessing.py index 6d20782a158..2b3ddcfcda7 100644 --- a/Lib/test/test_multiprocessing.py +++ b/Lib/test/test_multiprocessing.py @@ -270,7 +270,7 @@ class _TestProcess(BaseTestCase): @classmethod def _test_terminate(cls): - time.sleep(1000) + time.sleep(100) def test_terminate(self): if self.TYPE == 'threads': @@ -296,7 +296,19 @@ class _TestProcess(BaseTestCase): p.terminate() - self.assertEqual(join(), None) + if hasattr(signal, 'alarm'): + def handler(*args): + raise RuntimeError('join took too long: pid=%s' % p.pid) + old_handler = signal.signal(signal.SIGALRM, handler) + try: + signal.alarm(10) + self.assertEqual(join(), None) + signal.alarm(0) + finally: + signal.signal(signal.SIGALRM, old_handler) + else: + self.assertEqual(join(), None) + self.assertTimingAlmostEqual(join.elapsed, 0.0) self.assertEqual(p.is_alive(), False)