Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

Issue #20786: Fix signatures for dict.__delitem__ and property.__delete__

This commit is contained in:
Yury Selivanov 2014-03-02 12:25:27 -05:00
parent 6c6596ec52
commit 056e265491
3 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Lib/test/test_inspect.py
View File

@ -1764,6 +1764,11 @@ class TestSignatureObject(unittest.TestCase):
__call__ = type __call__ = type
test_callable(ThisWorksNow()) test_callable(ThisWorksNow())
# Regression test for issue #20786
test_unbound_method(dict.__delitem__)
test_unbound_method(property.__delete__)
@cpython_only @cpython_only
@unittest.skipIf(MISSING_C_DOCSTRINGS, @unittest.skipIf(MISSING_C_DOCSTRINGS,
"Signature information for builtins requires docstrings") "Signature information for builtins requires docstrings")

3
Misc/NEWS
View File

@ -14,6 +14,9 @@ Core and Builtins
- Issue #20637: Key-sharing now also works for instance dictionaries of - Issue #20637: Key-sharing now also works for instance dictionaries of
subclasses. Patch by Peter Ingebretson. subclasses. Patch by Peter Ingebretson.
- Issue #20786: Fix signatures for dict.__delitem__ and
property.__delete__ builtins.
Library Library
------- -------

4
Objects/typeobject.c
View File

@ -6192,7 +6192,7 @@ static slotdef slotdefs[] = {
"__set__($self, instance, value, /)\n--\n\nSet an attribute of instance to value."), "__set__($self, instance, value, /)\n--\n\nSet an attribute of instance to value."),
TPSLOT("__delete__", tp_descr_set, slot_tp_descr_set, TPSLOT("__delete__", tp_descr_set, slot_tp_descr_set,
wrap_descr_delete, wrap_descr_delete,
"__delete__(instance, /)\n--\n\nDelete an attribute of instance."), "__delete__($self, instance, /)\n--\n\nDelete an attribute of instance."),
FLSLOT("__init__", tp_init, slot_tp_init, (wrapperfunc)wrap_init, FLSLOT("__init__", tp_init, slot_tp_init, (wrapperfunc)wrap_init,
"__init__($self, /, *args, **kwargs)\n--\n\n" "__init__($self, /, *args, **kwargs)\n--\n\n"
"Initialize self. See help(type(self)) for accurate signature.", "Initialize self. See help(type(self)) for accurate signature.",
@ -6289,7 +6289,7 @@ static slotdef slotdefs[] = {
"__setitem__($self, key, value, /)\n--\n\nSet self[key] to value."), "__setitem__($self, key, value, /)\n--\n\nSet self[key] to value."),
MPSLOT("__delitem__", mp_ass_subscript, slot_mp_ass_subscript, MPSLOT("__delitem__", mp_ass_subscript, slot_mp_ass_subscript,
wrap_delitem, wrap_delitem,
"__delitem__(key)\n--\n\nDelete self[key]."), "__delitem__($self, key, /)\n--\n\nDelete self[key]."),
SQSLOT("__len__", sq_length, slot_sq_length, wrap_lenfunc, SQSLOT("__len__", sq_length, slot_sq_length, wrap_lenfunc,
"__len__($self, /)\n--\n\nReturn len(self)."), "__len__($self, /)\n--\n\nReturn len(self)."),