From 04e39ec81592915803bc253a6567153d18a2e71a Mon Sep 17 00:00:00 2001 From: Neal Norwitz Date: Mon, 17 Jul 2006 00:57:15 +0000 Subject: [PATCH] otherset is known to be non-NULL based on checks before and DECREF after. DECREF otherset rather than XDECREF in error conditions too. Reported by Klockwork #154. --- Objects/setobject.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Objects/setobject.c b/Objects/setobject.c index f10fdd795f2..3ddb6754753 100644 --- a/Objects/setobject.c +++ b/Objects/setobject.c @@ -1380,12 +1380,12 @@ set_symmetric_difference_update(PySetObject *so, PyObject *other) while (set_next(otherset, &pos, &entry)) { int rv = set_discard_entry(so, entry); if (rv == -1) { - Py_XDECREF(otherset); + Py_DECREF(otherset); return NULL; } if (rv == DISCARD_NOTFOUND) { if (set_add_entry(so, entry) == -1) { - Py_XDECREF(otherset); + Py_DECREF(otherset); return NULL; } }