- Issue #15906: Fix a regression in argparse caused by the preceding change,

when action='append', type='str' and default=[].
This commit is contained in:
Barry Warsaw 2012-09-11 21:06:29 -04:00
parent a8a5b397c1
commit 03fcfbef0a
3 changed files with 14 additions and 0 deletions

View File

@ -1948,6 +1948,7 @@ class ArgumentParser(_AttributeHolder, _ActionsContainer):
# twice (which may fail) if the argument was given, but
# only if it was defined already in the namespace
if (action.default is not None and
isinstance(action, _StoreAction) and
hasattr(namespace, action.dest) and
action.default is getattr(namespace, action.dest)):
setattr(namespace, action.dest,

View File

@ -4480,6 +4480,16 @@ class TestTypeFunctionCallWithNonStringDefault(TestCase):
args = parser.parse_args([])
self.assertEqual(NS(foo='foo_converted'), args)
def test_issue_15906(self):
# Issue #15906: When action='append', type=str, default=[] are
# providing, the dest value was the string representation "[]" when it
# should have been an empty list.
parser = argparse.ArgumentParser()
parser.add_argument('--test', dest='test', type=str,
default=[], action='append')
args = parser.parse_args([])
self.assertEqual(args.test, [])
# ======================
# parse_known_args tests
# ======================

View File

@ -119,6 +119,9 @@ Library
especially problematic for the FileType type, as a default file would always
be opened, even if a file argument was specified on the command line.
- Issue #15906: Fix a regression in argparse caused by the preceding change,
when action='append', type='str' and default=[].
- Issue #13370: Ensure that ctypes works on Mac OS X when Python is
compiled using the clang compiler