Mirror
/
cpython
mirror of https://github.com/python/cpython
4
1
Fork 0
Code Issues Releases Wiki Activity

gh-121200: Fix test_expanduser_pwd2() of test_posixpath (#121228) 

Call getpwnam() to get pw_dir, since it can be different than
getpwall() pw_dir.
This commit is contained in:
Victor Stinner 2024-07-01 17:49:03 +02:00 committed by GitHub
parent 8a5176772c
commit 02cb5fdee3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Lib/test/test_posixpath.py
View File

@ -359,11 +359,16 @@ class PosixPathTest(unittest.TestCase):
"no home directory on VxWorks")
def test_expanduser_pwd2(self):
pwd = import_helper.import_module('pwd')
for entry in pwd.getpwall():
name = entry.pw_name
for all_entry in pwd.getpwall():
name = all_entry.pw_name
# gh-121200: pw_dir can be different between getpwall() and
# getpwnam(), so use getpwnam() pw_dir as expanduser() does.
entry = pwd.getpwnam(name)
home = entry.pw_dir
home = home.rstrip('/') or '/'
with self.subTest(pwd=entry):
with self.subTest(all_entry=all_entry, entry=entry):
self.assertEqual(posixpath.expanduser('~' + name), home)
self.assertEqual(posixpath.expanduser(os.fsencode('~' + name)),
os.fsencode(home))

3
Misc/NEWS.d/next/Tests/2024-07-01-16-15-06.gh-issue-121200.4Pc-gc.rst Normal file
View File

@ -0,0 +1,3 @@
Fix ``test_expanduser_pwd2()`` of ``test_posixpath``. Call ``getpwnam()``
to get ``pw_dir``, since it can be different than ``getpwall()`` ``pw_dir``.
Patch by Victor Stinner.