4f8d2059f8
We are calling fabsf(), which returns a float. We should use the epsilon
from float type, not from the argument type passed to fabsf().
On the other hand when the double version is instantiated we do want to
use the std::numeric_limits<double>::epsilon() value.
This adds a branch to the function, but it's removed when the function
is intantiated by the compiler since the type is known at compile-time.
Fixes this warning when building for PX4:
../../libraries/AP_Math/AP_Math.cpp: In instantiation of 'typename std::enable_if<std::is_floating_point<typename std::common_type<_Tp, _Up>::type>::value, bool>::type is_equal(Arithmetic1, Arithmetic2) [with Arithmetic1 = double; Arithmetic2 = double; typename std::enable_if<std::is_floating_point<typename std::common_type<_Tp, _Up>::type>::value, bool>::type = bool]':
../../libraries/AP_Math/AP_Math.cpp:23:66: required from here
../../libraries/AP_Math/AP_Math.cpp:17:29: warning: implicit conversion from 'float' to 'double' to match other operand of binary expression [-Wdouble-promotion]
return fabsf(v_1 - v_2) < std::numeric_limits<decltype(v_1 - v_2)>::epsilon();
^
|
||
|---|---|---|
| .github | ||
| AntennaTracker | ||
| APMrover2 | ||
| ArduCopter | ||
| ArduPlane | ||
| benchmarks | ||
| docs | ||
| libraries | ||
| mk | ||
| modules | ||
| tests | ||
| Tools | ||
| .dir-locals.el | ||
| .editorconfig | ||
| .gitattributes | ||
| .gitignore | ||
| .gitmodules | ||
| .pydevproject | ||
| .travis.yml | ||
| BUILD.md | ||
| COPYING.txt | ||
| Doxyfile.in | ||
| eclipse.cproject | ||
| eclipse.project | ||
| Makefile | ||
| Makefile.waf | ||
| README.md | ||
| reformat.sh | ||
| uncrustify_cpp.cfg | ||
| uncrustify_headers.cfg | ||
| Vagrantfile | ||
| waf | ||
| wscript | ||
#ArduPilot Project#
The ArduPilot project is made up of:
User Support & Discussion Forums
Support Forum: http://discuss.ardupilot.org/
Community Site: http://ardupilot.org
Developer Information
Github repository: https://github.com/ArduPilot/ardupilot
Main developer wiki: http://dev.ardupilot.org
Developer email group: drones-discuss@googlegroups.com
Contributors
How To Get Involved
The ArduPilot project is open source and we encourage participation and code contributions: guidelines for contributors to the ardupilot codebase
We have an active group of Beta Testers especially for ArduCopter to help us find bugs: release procedures
Desired Enhancements and Bugs can be posted to the issues list.
Helping other users with log analysis on http://discuss.ardupilot.org/ is always appreciated:
There is a group of wiki editors as well in case documentation is your thing: ardu-wiki-editors@googlegroups.com
Developer discussions occur on drones-discuss@google-groups.com
License
Maintainers
Ardupilot is comprised of several parts, vehicles and boards. The list below contains the people that regularly contribute to the project and are responsible for reviewing patches on their specific area. See CONTRIBUTING.md for more information.
- Andrew Tridgell
- Vehicle: Plane, AntennaTracker
- Board: APM1, APM2, Pixhawk, Pixhawk2, PixRacer
- Randy Mackay
- Vehicle: Copter, AntennaTracker
- Robert Lefebvre
- Vehicle: TradHeli
- Grant Morphett:
- Vehicle: Rover
- [Tom Pittenger] (https://github.com/magicrub)
- Vehicle: Plane
- Paul Riseborough
- Subsystem: AP_NavEKF2
- Lucas De Marchi
- Subsystem: Linux
- Peter Barker
- Subsystem: DataFlash
- Subsystem: Tools
- Michael du Breuil
- Subsystem: uBlox GPS
- Francisco Ferreira
- Bug Master
- Matthias Badaire
- Subsystem: FRSky
- Víctor Mayoral Vilches
- Board: PXF, Erle-Brain 2, PXFmini
- Mirko Denecke
- Board: BBBmini, BeagleBone Blue
- Georgii Staroselskii
- Board: NavIO
- Emile Castelnuovo
- Board: VRBrain
- Julien BERAUD
- Board: Bebop & Bebop 2
- Pritam Ghanghas
- Board: Raspilot
- [Jonathan Challinger] (https://github.com/3drobotics/ardupilot-solo)
- Vehicle: 3DRobotics Solo ArduPilot maintainer
- Gustavo José de Sousa
- Subsystem: Build system
- [Craig Elder] (https://github.com/CraigElder)
- Administration: ArduPilot Technical Community Manager