c_str points to a member of .str(), so we have to make sure that object persists
../../libraries/SITL/SIM_XPlane.cpp:239:34: warning: object backing the pointer will be destroyed at the end of the full-expression [-Wdangling-gsl]
239 | const char *type_s = d.get("type").to_str().c_str();
... if the driver ever asked for prom0 then we would do Very Bad Things here.
File: build/sitl/../../libraries/SITL/SIM_Temperature_TSYS01.cpp
Warning: line 38, column 13
Assigned value is garbage or undefined
roll and pitch are unused if !SITL_RANGEFINDER_AS_OBJECT_SENSOR
../../libraries/SITL/SIM_Aircraft.cpp:546:13: warning: Value stored to 'roll' is never read [deadcode.DeadStores]
roll = 0;
^ ~
../../libraries/SITL/SIM_Aircraft.cpp:551:13: warning: Value stored to 'roll' is never read [deadcode.DeadStores]
roll = 0;
^ ~
../../libraries/SITL/SIM_Aircraft.cpp:557:13: warning: Value stored to 'pitch' is never read [deadcode.DeadStores]
pitch = 0;
^ ~
../../libraries/SITL/SIM_Aircraft.cpp:562:13: warning: Value stored to 'pitch' is never read [deadcode.DeadStores]
pitch = 0;
This makes SIM_ENGINE_FAIL work a little more intuitively, since it is
usually used to simulate a complete failure.
Also, drive-by fix of the SIM_ENGINE_MUL documentation.
- correctly fill data-ready register
- adjust for different register configuration the driver shoves in
- correct WHOAMI register length
- correct 8-bit register reads in variable-length-register i2c simulation
projecting onto an infinite plane can cause exceptionally long rangefinder distances - for now jsut cap the distance that the simulated rangefinder can return to avoid floating point exceptions.
the FPE is caused in the Plane FlyEachFrame autotest when flying quadplane-copter_tailsitter - which ends up with a rangefinder at yaw-minus-180.
Co-authored-by: Andrew Tridgell <andrew@tridgell.net>
uses the elements out of the simulated GPS data "d", rather than going to the parameters in teh simulated GPS "backends".
- checksum calculation was including header parts in CRC twice
- need to send DOP message to make EKF happy
- need to supply own number of satellites
- must pad packets to a multiple of 4 bytes
