Commit Graph

25 Commits

Author SHA1 Message Date
Thomas Watson d7b26a2205 AC_AutoTune: fix tracking of maximum angular acceleration
Issue introduced in https://github.com/ArduPilot/ardupilot/pull/27370
and partially fixed in https://github.com/ArduPilot/ardupilot/pull/27762,
though evidently not properly tested.

Failing to track the maximum can result in dangerously low values being
calculated for `ATC_ACCEL_[RPY]_MAX` and the vehicle becoming unflyable.

Make the variable a reference so that the maximum value is preserved
between function calls.
2024-12-05 09:18:56 +09:00
Leonard Hall a4a9113cde AC_Autotune: Fix bug introduced in #27370 2024-08-06 17:45:04 +10:00
Peter Barker 9397ece55a AC_AutoTune: make axis-type enum-class
Co-authored-by: Andrew Tridgell <andrew@tridgell.net>
2024-07-30 10:20:26 +10:00
Leonard Hall bea2c5b59b AC_Autotune: Clean up Multi Variables and non functional changes 2024-07-26 20:11:42 +10:00
Peter Barker 0ee787325a AC_AutoTune: NFC whitespace, ordering and add trailing comma to enumeration 2024-06-27 10:12:30 +10:00
Leonard Hall cebcbf0044 Copter: Autotune: Virtual methods to separate Heli and Multi 2024-05-29 18:29:23 +10:00
Leonard Hall 45525a40b8 Copter: Autotune: Don't Fail min D for Yaw Filter 2024-05-29 18:29:23 +10:00
Leonard Hall 858d90cb95 Copter: Autotune: Improve angle limit test 2024-05-29 18:29:23 +10:00
Peter Barker 2eede45f3a AC_AutoTune: allow compilation with HAL_LOGGING_ENABLED false 2024-01-17 18:25:55 +11:00
Peter Barker e95b1e5dd3 AC_AutoTune: add and use header guards 2023-12-12 11:36:15 +11:00
Mykhailo Kuznietsov ad0b0a1c05 AC_AutoTune: Fix some typos
Fixed some typos found in the code.
2023-10-12 18:30:42 +11:00
Iampete1 2ccf8af2bd AC_Autotune_Multi: print gains on axis completion 2022-02-23 07:44:24 +09:00
Bill Geyer fb5fec387e AC_AutoTune: consolidate gcs messages and add reset for update gain variables 2022-02-01 23:06:51 -05:00
Bill Geyer bc2455e285 AC_AutoTune: rename parameter for convention and put testing timeout in subclasses 2022-02-01 23:06:51 -05:00
Bill Geyer 5cfd0502f7 AC_AutoTune: add internal error check for cases and methods multi should never use 2022-02-01 23:06:51 -05:00
Bill Geyer 36d627c1b0 AC_AutoTune: adjust code to move parameter variables into subclasses 2022-02-01 23:06:51 -05:00
Bill Geyer c817e92ada AC_AutoTune: make incrementing the tune type a function 2022-02-01 23:06:51 -05:00
Bill Geyer a9d47532d0 AC_AutoTune: make initialize methods to restart testing 2022-02-01 23:06:51 -05:00
Bill Geyer 40321754fa AC_AutoTune: move load and backup gain methods to subclasses 2022-02-01 23:06:51 -05:00
Bill Geyer da947d4498 AC_AutoTune: move multi specific methods into sub class 2022-02-01 23:06:51 -05:00
Bill Geyer 716fcc1cba AC_AutoTune: additional commenting and clean up 2022-02-01 23:06:51 -05:00
Bill Geyer 9d7291f28a AC_AutoTune: removed pilot control during angle P tuning, added vel feedback 2022-02-01 23:06:51 -05:00
Bill Geyer c757de153d AC_AutoTune: tradheli autotune, sqashed commits together 2022-02-01 23:06:51 -05:00
Randy Mackay 873924d6cd AC_AutoTune: formatting and comment improvements 2022-02-01 23:06:51 -05:00
bnsgeyer fae1917aa7 AC_Autotune: add heli autotune with review comments incorporated 2022-02-01 23:06:51 -05:00