The cross-product code can produce something slightly negative. Fix
safe_sqrt to avoid barfing on that, as was originally intended, and
clarify why it's being used.
Co-authored-by: Leonard Hall <leonardthall@gmail.com>
Co-authored-by: Thomas Watson <twatson52@icloud.com>
There are currently issues where the non-.exe-suffixed files can't be
copied into the `artifacts` folder; `cp` claims "File exists".
Previously this worked but the suffix was added by Cygwin so all files
in `artifacts` had a `.exe` suffix anyway.
This is evidently intended, though non-intuitive, behavior:
https://sourceware.org/legacy-ml/cygwin/2009-08/msg00293.html
> On Cygwin, you should avoid having a file "foo" and a file "foo.exe"
> in the same directory at all cost to avoid puzzeling POSIX borderline
> behaviour like this. What you do is essentially in the "not
> supported" class of problems.
> [...] Cygwin does not check for a file "foo", if the name of the file
> is explicitely given as "foo.exe".
Apparently something similar was addressed in PR #20926; the current
code installs files with both suffixes, but that fix contradicts the
info above and now has broken.
This PR changes the code to only install .exe-suffixed files, as opposed
to only non-.exe-suffixed files, which was the behavior before that PR.
"> AP_INERTIALSENSOR_FAST_SAMPLE_WINDOW_ENABLED should never be built without harmonic notch support, so we should express the dependency a different way if necessary rather than littering the code with extra defines"
the original file these were copied from has a lower limit, so deserves this comment. These hwdefs are making the entire space available, so remove this comment.
- Resolve variable may be uninitialised error when compiling for ESP32.
- Exclude definition of clock_gettime for HAL_BOARD_ESP32
- Use #if not #ifdef for AP_DDS_GOAL_PUB_ENABLED
- Format #endif AP_DDS_GOAL_PUB_ENABLED
- Use #if not #ifdef for AP_DDS_STATUS_PUB_ENABLED
- Enclose rx_dynamic_transforms_topic declaration in #if ... #endif
- Enclose quaternion initializer in #if ... #endif
- AP_DDS_GOAL_PUB_ENABLED must also have AP_SCRIPTING_ENABLED
Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
AP_DDS: configuration fixes
Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
- FreeRTOS task functions must not return or exit.
- vTaskDelete(NULL) deletes the calling task.
Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
Explain more thoroughly how the test works using lessons learned from
studying the compiled bytecode and function data.
Tested that it still fails after reverting the patches in PR #27652.
