From ed58758ce61d4ff5cb3bfb064da0b3ae38c9444e Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Sun, 23 Jun 2024 12:15:26 +1000 Subject: [PATCH] hwdef: don't use DEFAULTGPIO in bootloaders setting up a DEFAULTGPIO pulldown in bootloaders is a bad idea as it overrides any hardware pullups that have been put in place as part of a "hold in bootloader" mechanism. See discussion in #27360 for ELRS note that this only impacts one board that I can see, the BlitzF745AIO, due to the MCU vs DEFAULTGPIO interaction --- libraries/AP_HAL_ChibiOS/hwdef/ARKV6X/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/BETAFPV-F405/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/BlitzF745/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/BlitzF745AIO/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/BlitzH743Pro/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/BotBloxSwitch/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/CBU-H7-Stamp/hwdef-bl.dat | 3 --- libraries/AP_HAL_ChibiOS/hwdef/FlywooF405Pro/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/FlywooF405S-AIO/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/FoxeerF405v2/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/FoxeerH743v1/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/JFB110/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/JHEMCU-H743HD/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/JHEM_JHEF405/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/KakuteH7/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/KakuteH7Mini/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/MambaH743v4/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/MicoAir405Mini/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/MicoAir405v2/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/MicoAir743/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/NxtPX4v2/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/OrqaF405Pro/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/Pixhawk5X/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/Pixhawk6C/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/Pixhawk6X/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/SPRacingH7/hwdef-bl.dat | 1 - libraries/AP_HAL_ChibiOS/hwdef/SPRacingH7RF/hwdef-bl.dat | 1 - libraries/AP_HAL_ChibiOS/hwdef/SkystarsH7HD/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/SpeedyBeeF405Mini/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/SpeedyBeeF405WING/hwdef-bl.dat | 2 -- libraries/AP_HAL_ChibiOS/hwdef/TMotorH743/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/modalai_fc-v1/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/speedybeef4v3/hwdef-bl.dat | 2 -- libraries/AP_HAL_ChibiOS/hwdef/speedybeef4v4/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/thepeach-k1/hwdef-bl.dat | 3 +-- libraries/AP_HAL_ChibiOS/hwdef/thepeach-r1/hwdef-bl.dat | 3 +-- 36 files changed, 31 insertions(+), 71 deletions(-) diff --git a/libraries/AP_HAL_ChibiOS/hwdef/ARKV6X/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/ARKV6X/hwdef-bl.dat index 4dc19548f3..2fb7970bf1 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/ARKV6X/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/ARKV6X/hwdef-bl.dat @@ -24,8 +24,7 @@ env OPTIMIZE -Os # order of UARTs (and USB) SERIAL_ORDER OTG1 UART7 UART5 USART3 -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # USB PA11 OTG_FS_DM OTG1 diff --git a/libraries/AP_HAL_ChibiOS/hwdef/BETAFPV-F405/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/BETAFPV-F405/hwdef-bl.dat index c3a9504378..ea7aec21b5 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/BETAFPV-F405/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/BETAFPV-F405/hwdef-bl.dat @@ -30,8 +30,7 @@ PA12 OTG_FS_DP OTG1 PA13 JTMS-SWDIO SWD PA14 JTCK-SWCLK SWD -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + PA10 USART1_RX USART1 HIGH PULLUP PB11 USART3_RX USART3 HIGH PULLUP diff --git a/libraries/AP_HAL_ChibiOS/hwdef/BlitzF745/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/BlitzF745/hwdef-bl.dat index 4b0c876789..3300a02844 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/BlitzF745/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/BlitzF745/hwdef-bl.dat @@ -30,8 +30,7 @@ PA12 OTG_FS_DP OTG1 PA13 JTMS-SWDIO SWD PA14 JTCK-SWCLK SWD -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # Chip select pins diff --git a/libraries/AP_HAL_ChibiOS/hwdef/BlitzF745AIO/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/BlitzF745AIO/hwdef-bl.dat index eb9a170bc8..7a226ae2b9 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/BlitzF745AIO/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/BlitzF745AIO/hwdef-bl.dat @@ -3,8 +3,7 @@ # for IFLIGHT_BLITZ_F7_AIO hardware. # thanks to betaflight for pin information -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # MCU class and specific type MCU STM32F7xx STM32F745xx diff --git a/libraries/AP_HAL_ChibiOS/hwdef/BlitzH743Pro/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/BlitzH743Pro/hwdef-bl.dat index 22afd74789..0f09931788 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/BlitzH743Pro/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/BlitzH743Pro/hwdef-bl.dat @@ -30,8 +30,7 @@ PA12 OTG_FS_DP OTG1 PA13 JTMS-SWDIO SWD PA14 JTCK-SWCLK SWD -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # Chip select pins diff --git a/libraries/AP_HAL_ChibiOS/hwdef/BotBloxSwitch/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/BotBloxSwitch/hwdef-bl.dat index f330a1c455..5984ec4712 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/BotBloxSwitch/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/BotBloxSwitch/hwdef-bl.dat @@ -1,8 +1,7 @@ # hw definition file for processing by chibios_hwdef.py # for the BotBloxSwitch hardware -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # MCU class and specific type MCU STM32H7xx STM32H723xx diff --git a/libraries/AP_HAL_ChibiOS/hwdef/CBU-H7-Stamp/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/CBU-H7-Stamp/hwdef-bl.dat index 77c422ffe0..5fe147cd65 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/CBU-H7-Stamp/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/CBU-H7-Stamp/hwdef-bl.dat @@ -1,9 +1,6 @@ # hw definition file for processing by chibios_hwdef.py # for the CBUnmanned H743 Stamp hardware -# default to all pins low to avoid ESD issues -#DEFAULTGPIO OUTPUT LOW PULLDOWN - # MCU class and specific type MCU STM32H7xx STM32H743xx diff --git a/libraries/AP_HAL_ChibiOS/hwdef/FlywooF405Pro/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/FlywooF405Pro/hwdef-bl.dat index b02a0ace60..aec6b5772b 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/FlywooF405Pro/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/FlywooF405Pro/hwdef-bl.dat @@ -30,8 +30,7 @@ PA12 OTG_FS_DP OTG1 PA13 JTMS-SWDIO SWD PA14 JTCK-SWCLK SWD -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # Chip select pins diff --git a/libraries/AP_HAL_ChibiOS/hwdef/FlywooF405S-AIO/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/FlywooF405S-AIO/hwdef-bl.dat index 56dcdc07d8..5d0ef165e5 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/FlywooF405S-AIO/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/FlywooF405S-AIO/hwdef-bl.dat @@ -30,8 +30,7 @@ PA12 OTG_FS_DP OTG1 PA13 JTMS-SWDIO SWD PA14 JTCK-SWCLK SWD -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # Chip select pins diff --git a/libraries/AP_HAL_ChibiOS/hwdef/FoxeerF405v2/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/FoxeerF405v2/hwdef-bl.dat index fc17a78863..e9ef89d24e 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/FoxeerF405v2/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/FoxeerF405v2/hwdef-bl.dat @@ -27,8 +27,7 @@ SERIAL_ORDER OTG1 PA11 OTG_FS_DM OTG1 PA12 OTG_FS_DP OTG1 -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # Chip select pins diff --git a/libraries/AP_HAL_ChibiOS/hwdef/FoxeerH743v1/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/FoxeerH743v1/hwdef-bl.dat index e12dd8df1e..3106a80968 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/FoxeerH743v1/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/FoxeerH743v1/hwdef-bl.dat @@ -30,8 +30,7 @@ PA12 OTG_FS_DP OTG1 PA13 JTMS-SWDIO SWD PA14 JTCK-SWCLK SWD -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # Chip select pins diff --git a/libraries/AP_HAL_ChibiOS/hwdef/JFB110/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/JFB110/hwdef-bl.dat index 6a7b2f739b..6e564b78f1 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/JFB110/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/JFB110/hwdef-bl.dat @@ -42,8 +42,7 @@ SERIAL_ORDER OTG1 UART7 UART5 USART3 STDOUT_SERIAL SD3 STDOUT_BAUDRATE 921600 -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # USB OTG1 SERIAL0 PA11 OTG_FS_DM OTG1 diff --git a/libraries/AP_HAL_ChibiOS/hwdef/JHEMCU-H743HD/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/JHEMCU-H743HD/hwdef-bl.dat index e8a9001abc..66e51185c6 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/JHEMCU-H743HD/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/JHEMCU-H743HD/hwdef-bl.dat @@ -32,8 +32,7 @@ PA12 OTG_FS_DP OTG1 PA13 JTMS-SWDIO SWD PA14 JTCK-SWCLK SWD -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # Chip select pins diff --git a/libraries/AP_HAL_ChibiOS/hwdef/JHEM_JHEF405/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/JHEM_JHEF405/hwdef-bl.dat index dd81acb853..b579c42686 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/JHEM_JHEF405/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/JHEM_JHEF405/hwdef-bl.dat @@ -34,8 +34,7 @@ PA12 OTG_FS_DP OTG1 PA13 JTMS-SWDIO SWD PA14 JTCK-SWCLK SWD -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # Chip select pins diff --git a/libraries/AP_HAL_ChibiOS/hwdef/KakuteH7/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/KakuteH7/hwdef-bl.dat index a39b007629..b70f466f51 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/KakuteH7/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/KakuteH7/hwdef-bl.dat @@ -35,8 +35,7 @@ PC13 BUZZER OUTPUT LOW PULLDOWN PC2 LED_BOOTLOADER OUTPUT LOW define HAL_LED_ON 1 -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # Add CS pins to ensure they are high in bootloader PE4 IMU_CS CS diff --git a/libraries/AP_HAL_ChibiOS/hwdef/KakuteH7Mini/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/KakuteH7Mini/hwdef-bl.dat index c66e93ba9d..d618ce194c 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/KakuteH7Mini/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/KakuteH7Mini/hwdef-bl.dat @@ -35,8 +35,7 @@ PC13 BUZZER OUTPUT LOW PULLDOWN PC2 LED_BOOTLOADER OUTPUT LOW define HAL_LED_ON 1 -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # Add CS pins to ensure they are high in bootloader PE4 IMU_CS CS diff --git a/libraries/AP_HAL_ChibiOS/hwdef/MambaH743v4/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/MambaH743v4/hwdef-bl.dat index 201ffc4df0..8c1217136f 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/MambaH743v4/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/MambaH743v4/hwdef-bl.dat @@ -33,8 +33,7 @@ PE3 BUZZER OUTPUT LOW PULLDOWN PE5 LED_BOOTLOADER OUTPUT LOW define HAL_LED_ON 1 -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + PC5 VTX_PWR OUTPUT HIGH diff --git a/libraries/AP_HAL_ChibiOS/hwdef/MicoAir405Mini/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/MicoAir405Mini/hwdef-bl.dat index dd60bfdedd..efd6b50a50 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/MicoAir405Mini/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/MicoAir405Mini/hwdef-bl.dat @@ -27,8 +27,7 @@ SERIAL_ORDER OTG1 PA11 OTG_FS_DM OTG1 PA12 OTG_FS_DP OTG1 -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + #CS pin PB12 AT7456E_CS CS diff --git a/libraries/AP_HAL_ChibiOS/hwdef/MicoAir405v2/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/MicoAir405v2/hwdef-bl.dat index b205eae079..2422b94699 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/MicoAir405v2/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/MicoAir405v2/hwdef-bl.dat @@ -31,8 +31,7 @@ PA12 OTG_FS_DP OTG1 PA13 JTMS-SWDIO SWD PA14 JTCK-SWCLK SWD -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + #CS pin PB12 AT7456E_CS CS diff --git a/libraries/AP_HAL_ChibiOS/hwdef/MicoAir743/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/MicoAir743/hwdef-bl.dat index 28a492deb8..c111bbb75a 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/MicoAir743/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/MicoAir743/hwdef-bl.dat @@ -19,8 +19,7 @@ FLASH_RESERVE_START_KB 0 # the location where the bootloader will put the firmware FLASH_BOOTLOADER_LOAD_KB 128 -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # order of UARTs (and USB) SERIAL_ORDER OTG1 USART1 diff --git a/libraries/AP_HAL_ChibiOS/hwdef/NxtPX4v2/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/NxtPX4v2/hwdef-bl.dat index 887f3b99bc..6a28cbbca1 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/NxtPX4v2/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/NxtPX4v2/hwdef-bl.dat @@ -19,8 +19,7 @@ FLASH_RESERVE_START_KB 0 # the location where the bootloader will put the firmware FLASH_BOOTLOADER_LOAD_KB 128 -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # order of UARTs (and USB) SERIAL_ORDER OTG1 diff --git a/libraries/AP_HAL_ChibiOS/hwdef/OrqaF405Pro/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/OrqaF405Pro/hwdef-bl.dat index f602396f6e..78ad6e6362 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/OrqaF405Pro/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/OrqaF405Pro/hwdef-bl.dat @@ -30,8 +30,7 @@ PA12 OTG_FS_DP OTG1 PA13 JTMS-SWDIO SWD PA14 JTCK-SWCLK SWD -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # Chip select pins diff --git a/libraries/AP_HAL_ChibiOS/hwdef/Pixhawk5X/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/Pixhawk5X/hwdef-bl.dat index 82db60d63e..73b2dc8ec5 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/Pixhawk5X/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/Pixhawk5X/hwdef-bl.dat @@ -29,8 +29,7 @@ env OPTIMIZE -Os # order of UARTs (and USB) SERIAL_ORDER OTG1 UART7 UART5 USART2 USART3 -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # USB PA11 OTG_FS_DM OTG1 diff --git a/libraries/AP_HAL_ChibiOS/hwdef/Pixhawk6C/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/Pixhawk6C/hwdef-bl.dat index e80be6d002..3894214702 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/Pixhawk6C/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/Pixhawk6C/hwdef-bl.dat @@ -29,8 +29,7 @@ env OPTIMIZE -Os # order of UARTs (and USB) SERIAL_ORDER OTG1 UART7 UART5 USART3 -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # USB PA11 OTG_FS_DM OTG1 diff --git a/libraries/AP_HAL_ChibiOS/hwdef/Pixhawk6X/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/Pixhawk6X/hwdef-bl.dat index a8da550956..b9901fa1c7 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/Pixhawk6X/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/Pixhawk6X/hwdef-bl.dat @@ -24,8 +24,7 @@ env OPTIMIZE -Os # order of UARTs (and USB) SERIAL_ORDER OTG1 UART7 UART5 USART3 -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # USB PA11 OTG_FS_DM OTG1 diff --git a/libraries/AP_HAL_ChibiOS/hwdef/SPRacingH7/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/SPRacingH7/hwdef-bl.dat index 51200e048d..f5ef8f9ad8 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/SPRacingH7/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/SPRacingH7/hwdef-bl.dat @@ -53,7 +53,6 @@ QSPIDEV w25q-dtr QUADSPI1 MODE3 100*MHZ 24 1 define HAL_USE_EMPTY_STORAGE 1 define HAL_STORAGE_SIZE 16384 -DEFAULTGPIO OUTPUT LOW PULLDOWN # Add CS pins to ensure they are high in bootloader PB12 ICM20602_2_CS CS diff --git a/libraries/AP_HAL_ChibiOS/hwdef/SPRacingH7RF/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/SPRacingH7RF/hwdef-bl.dat index 4a2c734dc0..7278d62b5e 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/SPRacingH7RF/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/SPRacingH7RF/hwdef-bl.dat @@ -56,7 +56,6 @@ OSPIDEV w25q OCTOSPI1 MODE3 130*MHZ 21 1 define HAL_USE_EMPTY_STORAGE 1 define HAL_STORAGE_SIZE 16384 -DEFAULTGPIO OUTPUT LOW PULLDOWN # Add CS pins to ensure they are high in bootloader PA15 ICM42688_CS CS diff --git a/libraries/AP_HAL_ChibiOS/hwdef/SkystarsH7HD/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/SkystarsH7HD/hwdef-bl.dat index e51f307f0e..7453b722da 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/SkystarsH7HD/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/SkystarsH7HD/hwdef-bl.dat @@ -38,8 +38,7 @@ PE4 LED_ACTIVITY OUTPUT HIGH define HAL_LED_ON 0 define HAL_LED_OFF 1 -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # Add CS pins to ensure they are high in bootloader PC15 BMI270_CS1 CS diff --git a/libraries/AP_HAL_ChibiOS/hwdef/SpeedyBeeF405Mini/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/SpeedyBeeF405Mini/hwdef-bl.dat index e043e37c01..9d8245d987 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/SpeedyBeeF405Mini/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/SpeedyBeeF405Mini/hwdef-bl.dat @@ -30,8 +30,7 @@ PA12 OTG_FS_DP OTG1 PA13 JTMS-SWDIO SWD PA14 JTCK-SWCLK SWD -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # Chip select pins diff --git a/libraries/AP_HAL_ChibiOS/hwdef/SpeedyBeeF405WING/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/SpeedyBeeF405WING/hwdef-bl.dat index 84d03b16a6..6e9056e32f 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/SpeedyBeeF405WING/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/SpeedyBeeF405WING/hwdef-bl.dat @@ -29,8 +29,6 @@ SERIAL_ORDER OTG1 PA11 OTG_FS_DM OTG1 PA12 OTG_FS_DP OTG1 -DEFAULTGPIO OUTPUT LOW PULLDOWN - # Add CS pins to ensure they are high in bootloader PA4 MPU_CS CS PB12 OSD_CS CS diff --git a/libraries/AP_HAL_ChibiOS/hwdef/TMotorH743/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/TMotorH743/hwdef-bl.dat index 69385f40cf..9a8ae479ef 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/TMotorH743/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/TMotorH743/hwdef-bl.dat @@ -30,8 +30,7 @@ PA12 OTG_FS_DP OTG1 PA13 JTMS-SWDIO SWD PA14 JTCK-SWCLK SWD -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # Chip select pins diff --git a/libraries/AP_HAL_ChibiOS/hwdef/modalai_fc-v1/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/modalai_fc-v1/hwdef-bl.dat index ad8fae7466..0fa31b9c2b 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/modalai_fc-v1/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/modalai_fc-v1/hwdef-bl.dat @@ -10,8 +10,7 @@ OSCILLATOR_HZ 16000000 # board ID for firmware load APJ_BOARD_ID 41775 -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + FLASH_SIZE_KB 2048 diff --git a/libraries/AP_HAL_ChibiOS/hwdef/speedybeef4v3/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/speedybeef4v3/hwdef-bl.dat index 658ee1b32f..b1fd316c40 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/speedybeef4v3/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/speedybeef4v3/hwdef-bl.dat @@ -31,8 +31,6 @@ SERIAL_ORDER OTG1 PA11 OTG_FS_DM OTG1 PA12 OTG_FS_DP OTG1 -DEFAULTGPIO OUTPUT LOW PULLDOWN - # Add CS pins to ensure they are high in bootloader PA4 MPU6000_CS CS PB12 MAX7456_CS CS diff --git a/libraries/AP_HAL_ChibiOS/hwdef/speedybeef4v4/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/speedybeef4v4/hwdef-bl.dat index 743300b3b8..e392dc6199 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/speedybeef4v4/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/speedybeef4v4/hwdef-bl.dat @@ -30,8 +30,7 @@ PA12 OTG_FS_DP OTG1 PA13 JTMS-SWDIO SWD PA14 JTCK-SWCLK SWD -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + # Chip select pins diff --git a/libraries/AP_HAL_ChibiOS/hwdef/thepeach-k1/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/thepeach-k1/hwdef-bl.dat index b88c8ea999..7891eecab2 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/thepeach-k1/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/thepeach-k1/hwdef-bl.dat @@ -77,5 +77,4 @@ PC15 ICM20602_CS CS PD7 MS5611_CS CS PD10 FRAM_CS CS SPEED_VERYLOW -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN + diff --git a/libraries/AP_HAL_ChibiOS/hwdef/thepeach-r1/hwdef-bl.dat b/libraries/AP_HAL_ChibiOS/hwdef/thepeach-r1/hwdef-bl.dat index 6e85b46109..23bf5178fb 100644 --- a/libraries/AP_HAL_ChibiOS/hwdef/thepeach-r1/hwdef-bl.dat +++ b/libraries/AP_HAL_ChibiOS/hwdef/thepeach-r1/hwdef-bl.dat @@ -77,5 +77,4 @@ PC15 ICM20602_CS CS PD7 MS5611_CS CS PD10 FRAM_CS CS SPEED_VERYLOW -# default to all pins low to avoid ESD issues -DEFAULTGPIO OUTPUT LOW PULLDOWN +