Mirror/ardupilot
5
0
Fork 0
mirror of https://github.com/ArduPilot/ardupilot synced 2025-01-08 17:08:28 -04:00
Code Issues Packages Projects Releases Wiki Activity

AP_Compass: rename COMPASS_TYPEMASK to COMPASS_DISBLMSK

Browse Source 
this is a very confusingly named parameter.  I've seen several instances of people treating this as an enable mask rather than a disable mask
This commit is contained in:
Peter Barker 2024-01-22 13:24:58 +11:00 committed by Andrew Tridgell
parent 140518da3c
commit ecc7188d97
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libraries/AP_Compass/AP_Compass.cpp
View File

@ -508,12 +508,12 @@ const AP_Param::GroupInfo Compass::var_info[] = {
AP_SUBGROUPINFO(_per_motor, "PMOT", 32, Compass, Compass_PerMotor), AP_SUBGROUPINFO(_per_motor, "PMOT", 32, Compass, Compass_PerMotor),
#endif #endif
// @Param: TYPEMASK // @Param: DISBLMSK
// @DisplayName: Compass disable driver type mask // @DisplayName: Compass disable driver type mask
// @Description: This is a bitmask of driver types to disable. If a driver type is set in this mask then that driver will not try to find a sensor at startup // @Description: This is a bitmask of driver types to disable. If a driver type is set in this mask then that driver will not try to find a sensor at startup
// @Bitmask: 0:HMC5883,1:LSM303D,2:AK8963,3:BMM150,4:LSM9DS1,5:LIS3MDL,6:AK09916,7:IST8310,8:ICM20948,9:MMC3416,11:DroneCAN,12:QMC5883,14:MAG3110,15:IST8308,16:RM3100,17:MSP,18:ExternalAHRS // @Bitmask: 0:HMC5883,1:LSM303D,2:AK8963,3:BMM150,4:LSM9DS1,5:LIS3MDL,6:AK09916,7:IST8310,8:ICM20948,9:MMC3416,11:DroneCAN,12:QMC5883,14:MAG3110,15:IST8308,16:RM3100,17:MSP,18:ExternalAHRS
// @User: Advanced // @User: Advanced
AP_GROUPINFO("TYPEMASK", 33, Compass, _driver_type_mask, 0), AP_GROUPINFO("DISBLMSK", 33, Compass, _driver_type_mask, 0),
// @Param: FLTR_RNG // @Param: FLTR_RNG
// @DisplayName: Range in which sample is accepted // @DisplayName: Range in which sample is accepted

2
libraries/AP_Compass/AP_Compass.h
View File

@ -422,7 +422,7 @@ private:
bool _cal_requires_reboot; bool _cal_requires_reboot;
bool _cal_has_run; bool _cal_has_run;
// enum of drivers for COMPASS_TYPEMASK // enum of drivers for COMPASS_DISBLMSK
enum DriverType { enum DriverType {
#if AP_COMPASS_HMC5843_ENABLED #if AP_COMPASS_HMC5843_ENABLED
DRIVER_HMC5843 =0, DRIVER_HMC5843 =0,