Mirror
/
ardupilot
mirror of https://github.com/ArduPilot/ardupilot
5
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

AP_Logger: avoid all opens of log files in main thread 

this fixes a problem with sdcards where file open is very slow. It can
trigger a watchdog if it is slow enough. Peter and I hit this issue on
a pixracer today with a new sd card
This commit is contained in:
Andrew Tridgell 2021-10-31 18:44:17 +11:00 committed by Randy Mackay
parent f21e00a3ef
commit d59caa95ad
1 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
libraries/AP_Logger/AP_Logger_File.cpp
View File

@ -130,7 +130,8 @@ void AP_Logger_File::periodic_1Hz()
erase.was_logging) { erase.was_logging) {
// restart logging after an erase if needed // restart logging after an erase if needed
erase.was_logging = false; erase.was_logging = false;
start_new_log(); // setup to open the log in the backend thread
start_new_log_pending = true;
} }
if (_initialised && if (_initialised &&
@ -138,15 +139,8 @@ void AP_Logger_File::periodic_1Hz()
_write_fd == -1 && _read_fd == -1 && _write_fd == -1 && _read_fd == -1 &&
logging_enabled() && logging_enabled() &&
!recent_open_error()) { !recent_open_error()) {
// retry logging open. This allows for booting with // setup to open the log in the backend thread
// LOG_DISARMED=1 with a bad microSD or no microSD. Once a start_new_log_pending = true;
// card is inserted then logging starts
// this also allows for logging to start after forced arming
if (!hal.util->get_soft_armed()) {
start_new_log();
} else {
start_new_log_pending = true;
}
} }
if (!io_thread_alive()) { if (!io_thread_alive()) {