From d49f10d2e58f62729812aeb7bec6b445c773ba44 Mon Sep 17 00:00:00 2001 From: Gustavo Jose de Sousa Date: Tue, 11 Aug 2015 16:28:41 +1000 Subject: [PATCH] AC_AttitudeControl: standardize inclusion of libaries headers This commit changes the way libraries headers are included in source files: - If the header is in the same directory the source belongs to, so the notation '#include ""' is used with the path relative to the directory containing the source. - If the header is outside the directory containing the source, then we use the notation '#include <>' with the path relative to libraries folder. Some of the advantages of such approach: - Only one search path for libraries headers. - OSs like Windows may have a better lookup time. --- .../AC_AttitudeControl/AC_AttitudeControl.cpp | 4 ++-- .../AC_AttitudeControl/AC_AttitudeControl.h | 16 +++++++-------- .../AC_AttitudeControl_Heli.cpp | 2 +- .../AC_AttitudeControl_Heli.h | 8 ++++---- .../AC_AttitudeControl_Multi.cpp | 4 ++-- .../AC_AttitudeControl_Multi.h | 4 ++-- .../AC_AttitudeControl/AC_PosControl.cpp | 6 +++--- libraries/AC_AttitudeControl/AC_PosControl.h | 20 +++++++++---------- 8 files changed, 32 insertions(+), 32 deletions(-) diff --git a/libraries/AC_AttitudeControl/AC_AttitudeControl.cpp b/libraries/AC_AttitudeControl/AC_AttitudeControl.cpp index 3b858c51ee..22d6939a27 100644 --- a/libraries/AC_AttitudeControl/AC_AttitudeControl.cpp +++ b/libraries/AC_AttitudeControl/AC_AttitudeControl.cpp @@ -1,8 +1,8 @@ // -*- tab-width: 4; Mode: C++; c-basic-offset: 4; indent-tabs-mode: t -*- #include "AC_AttitudeControl.h" -#include -#include +#include +#include // table of user settable parameters const AP_Param::GroupInfo AC_AttitudeControl::var_info[] PROGMEM = { diff --git a/libraries/AC_AttitudeControl/AC_AttitudeControl.h b/libraries/AC_AttitudeControl/AC_AttitudeControl.h index 6e99ef7d7b..de06b021b6 100644 --- a/libraries/AC_AttitudeControl/AC_AttitudeControl.h +++ b/libraries/AC_AttitudeControl/AC_AttitudeControl.h @@ -6,14 +6,14 @@ #ifndef AC_AttitudeControl_H #define AC_AttitudeControl_H -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include // To-Do: change the name or move to AP_Math? #define AC_ATTITUDE_CONTROL_DEGX100 5729.57795f // constant to convert from radians to centi-degrees diff --git a/libraries/AC_AttitudeControl/AC_AttitudeControl_Heli.cpp b/libraries/AC_AttitudeControl/AC_AttitudeControl_Heli.cpp index bc9fa7fbb4..3552005c83 100644 --- a/libraries/AC_AttitudeControl/AC_AttitudeControl_Heli.cpp +++ b/libraries/AC_AttitudeControl/AC_AttitudeControl_Heli.cpp @@ -1,7 +1,7 @@ // -*- tab-width: 4; Mode: C++; c-basic-offset: 4; indent-tabs-mode: t -*- #include "AC_AttitudeControl_Heli.h" -#include +#include // table of user settable parameters const AP_Param::GroupInfo AC_AttitudeControl_Heli::var_info[] PROGMEM = { diff --git a/libraries/AC_AttitudeControl/AC_AttitudeControl_Heli.h b/libraries/AC_AttitudeControl/AC_AttitudeControl_Heli.h index 60c2cf9963..5c739efd4c 100644 --- a/libraries/AC_AttitudeControl/AC_AttitudeControl_Heli.h +++ b/libraries/AC_AttitudeControl/AC_AttitudeControl_Heli.h @@ -6,10 +6,10 @@ #ifndef AC_ATTITUDECONTROL_HELI_H #define AC_ATTITUDECONTROL_HELI_H -#include -#include -#include -#include +#include "AC_AttitudeControl.h" +#include +#include +#include #define AC_ATTITUDE_HELI_RATE_INTEGRATOR_LEAK_RATE 0.02f #define AC_ATTITUDE_HELI_RATE_RP_FF_FILTER 10.0f diff --git a/libraries/AC_AttitudeControl/AC_AttitudeControl_Multi.cpp b/libraries/AC_AttitudeControl/AC_AttitudeControl_Multi.cpp index 62a75342d0..223daa9cac 100644 --- a/libraries/AC_AttitudeControl/AC_AttitudeControl_Multi.cpp +++ b/libraries/AC_AttitudeControl/AC_AttitudeControl_Multi.cpp @@ -1,8 +1,8 @@ // -*- tab-width: 4; Mode: C++; c-basic-offset: 4; indent-tabs-mode: t -*- #include "AC_AttitudeControl_Multi.h" -#include -#include +#include +#include // returns a throttle including compensation for roll/pitch angle // throttle value should be 0 ~ 1000 diff --git a/libraries/AC_AttitudeControl/AC_AttitudeControl_Multi.h b/libraries/AC_AttitudeControl/AC_AttitudeControl_Multi.h index 7632a9ad05..a78aaa48c0 100644 --- a/libraries/AC_AttitudeControl/AC_AttitudeControl_Multi.h +++ b/libraries/AC_AttitudeControl/AC_AttitudeControl_Multi.h @@ -6,8 +6,8 @@ #ifndef AC_AttitudeControl_Multi_H #define AC_AttitudeControl_Multi_H -#include -#include +#include "AC_AttitudeControl.h" +#include class AC_AttitudeControl_Multi : public AC_AttitudeControl { public: diff --git a/libraries/AC_AttitudeControl/AC_PosControl.cpp b/libraries/AC_AttitudeControl/AC_PosControl.cpp index 62daae5ea8..5a8043398c 100644 --- a/libraries/AC_AttitudeControl/AC_PosControl.cpp +++ b/libraries/AC_AttitudeControl/AC_PosControl.cpp @@ -1,7 +1,7 @@ /// -*- tab-width: 4; Mode: C++; c-basic-offset: 4; indent-tabs-mode: nil -*- -#include -#include -#include +#include +#include "AC_PosControl.h" +#include extern const AP_HAL::HAL& hal; diff --git a/libraries/AC_AttitudeControl/AC_PosControl.h b/libraries/AC_AttitudeControl/AC_PosControl.h index 488b14dbc0..3b6594b6e5 100644 --- a/libraries/AC_AttitudeControl/AC_PosControl.h +++ b/libraries/AC_AttitudeControl/AC_PosControl.h @@ -2,16 +2,16 @@ #ifndef AC_POSCONTROL_H #define AC_POSCONTROL_H -#include -#include -#include -#include // PID library -#include // PID library (2-axis) -#include // P library -#include // Inertial Navigation library -#include // Attitude control library -#include // motors library -#include // common vehicle parameters +#include +#include +#include +#include // PID library +#include // PID library (2-axis) +#include // P library +#include // Inertial Navigation library +#include "AC_AttitudeControl.h" // Attitude control library +#include // motors library +#include // common vehicle parameters // position controller default definitions