Mirror/ardupilot
5
0
Fork 0
mirror of https://github.com/ArduPilot/ardupilot synced 2025-01-03 06:28:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

AP_LandingGear: removed create() method for objects

Browse Source 
See discussion here:

  https://github.com/ArduPilot/ardupilot/issues/7331

we were getting some uninitialised variables. While it only showed up in
AP_SbusOut, it means we can't be sure it won't happen on other objects,
so safest to remove the approach

Thanks to assistance from Lucas, Peter and Francisco
This commit is contained in:
Andrew Tridgell 2017-12-13 12:06:12 +11:00
parent 31092da426
commit ad99b04de7
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libraries/AP_LandingGear/AP_LandingGear.h
View File

@ -12,9 +12,10 @@
/// @brief Class managing the control of landing gear /// @brief Class managing the control of landing gear
class AP_LandingGear { class AP_LandingGear {
public: public:
static AP_LandingGear create() { return AP_LandingGear{}; } AP_LandingGear() {
// setup parameter defaults
constexpr AP_LandingGear(AP_LandingGear &&other) = default; AP_Param::setup_object_defaults(this, var_info);
}
/* Do not allow copies */ /* Do not allow copies */
AP_LandingGear(const AP_LandingGear &other) = delete; AP_LandingGear(const AP_LandingGear &other) = delete;
@ -46,11 +47,6 @@ public:
static const struct AP_Param::GroupInfo var_info[]; static const struct AP_Param::GroupInfo var_info[];
private: private:
AP_LandingGear() {
// setup parameter defaults
AP_Param::setup_object_defaults(this, var_info);
}
// Parameters // Parameters
AP_Int16 _servo_retract_pwm; // PWM value to move servo to when gear is retracted AP_Int16 _servo_retract_pwm; // PWM value to move servo to when gear is retracted
AP_Int16 _servo_deploy_pwm; // PWM value to move servo to when gear is deployed AP_Int16 _servo_deploy_pwm; // PWM value to move servo to when gear is deployed