Mirror/ardupilot
5
0
Fork 0
mirror of https://github.com/ArduPilot/ardupilot synced 2025-01-03 06:28:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

AntennaTracker: stop libraries including AP_Logger.h in .h files

Browse Source 
AP_Logger.h is a nexus of includes; while this is being improved over
time, there's no reason for the library headers to include AP_Logger.h
as the logger itself is access by singleton and the structures are in
LogStructure.h

This necessitated moving The PID_Info structure out of AP_Logger's
namespace.  This cleans up a pretty nasty bit - that structure is
definitely not simply used for logging, but also used to pass pid
information around to controllers!

There are a lot of patches in here because AP_Logger.h, acting as a
nexus, was providing transitive header file inclusion in many (some
unlikely!) places.
This commit is contained in:
Peter Barker 2022-03-04 14:29:49 +11:00 committed by Peter Barker
parent d319370080
commit 9d7cbf86f5
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
AntennaTracker/GCS_Mavlink.cpp
View File

@ -128,8 +128,7 @@ void GCS_MAVLINK_Tracker::send_pid_tuning()
// Pitch PID
if (g.gcs_pid_mask & 1) {
const AP_Logger::PID_Info *pid_info;
pid_info = &g.pidPitch2Srv.get_pid_info();
const AP_PIDInfo *pid_info = &g.pidPitch2Srv.get_pid_info();
mavlink_msg_pid_tuning_send(chan, PID_TUNING_PITCH,
pid_info->target,
pid_info->actual,
@ -146,8 +145,7 @@ void GCS_MAVLINK_Tracker::send_pid_tuning()
// Yaw PID
if (g.gcs_pid_mask & 2) {
const AP_Logger::PID_Info *pid_info;
pid_info = &g.pidYaw2Srv.get_pid_info();
const AP_PIDInfo *pid_info = &g.pidYaw2Srv.get_pid_info();
mavlink_msg_pid_tuning_send(chan, PID_TUNING_YAW,
pid_info->target,
pid_info->actual,